Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2328263004:
Fix GaussianEdgeShader GLSL code (Closed)
|
Created:
4 years, 3 months ago by jvanverth1 Modified:
4 years, 3 months ago CC:
reviews_skia.org Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionFix GaussianEdgeShader GLSL code
Implicit conversion of int constants to float is not always
guaranteed
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004
TBR=herbderby@google.com
NOTRY=true
NOTREECHECKS=true
Committed: https://skia.googlesource.com/skia/+/db85665578f19dde2779842488b3054da9b0b7e2
Patch Set 1 #
Total comments: 2
Messages
Total messages: 18 (11 generated)
Description was changed from ========== Fix GaussianEdgeShader GLSL code Converting int constants to float is not always guaranteed ========== to ========== Fix GaussianEdgeShader GLSL code Converting int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 ==========
Description was changed from ========== Fix GaussianEdgeShader GLSL code Converting int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 ========== to ========== Fix GaussianEdgeShader GLSL code Converting int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 ==========
jvanverth@google.com changed reviewers: + herbderby@gmail.com
Description was changed from ========== Fix GaussianEdgeShader GLSL code Converting int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 ========== to ========== Fix GaussianEdgeShader GLSL code Implicit conversion int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 ==========
Description was changed from ========== Fix GaussianEdgeShader GLSL code Implicit conversion int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 ========== to ========== Fix GaussianEdgeShader GLSL code Implicit conversion of int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 ==========
jvanverth@google.com changed reviewers: + egdaniel@google.com
lgtm, too bad Ethan's change got reverted or else this would have worked :) https://codereview.chromium.org/2328263004/diff/1/src/effects/SkGaussianEdgeS... File src/effects/SkGaussianEdgeShader.cpp (right): https://codereview.chromium.org/2328263004/diff/1/src/effects/SkGaussianEdgeS... src/effects/SkGaussianEdgeShader.cpp:95: fragBuilder->codeAppendf("float factor = 1.0 - clamp((%s.z - pad)/radius, 0.0, 1.0);", 100 chars https://codereview.chromium.org/2328263004/diff/1/src/effects/SkGaussianEdgeS... src/effects/SkGaussianEdgeShader.cpp:105: fragBuilder->codeAppendf("float factor = 1.0 - clamp((%s.z - pad)/radius, 0.0, 1.0);", 100chars
Description was changed from ========== Fix GaussianEdgeShader GLSL code Implicit conversion of int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 ========== to ========== Fix GaussianEdgeShader GLSL code Implicit conversion of int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 TBR=herbderby@google.com NOTRY=true NOTREECHECKS=true ==========
The CQ bit was checked by jvanverth@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
herb@google.com changed reviewers: + herb@google.com
lgtm
Message was sent while issue was closed.
Description was changed from ========== Fix GaussianEdgeShader GLSL code Implicit conversion of int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 TBR=herbderby@google.com NOTRY=true NOTREECHECKS=true ========== to ========== Fix GaussianEdgeShader GLSL code Implicit conversion of int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 TBR=herbderby@google.com NOTRY=true NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/db85665578f19dde2779842488b3054da9b0b7e2 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/db85665578f19dde2779842488b3054da9b0b7e2
Message was sent while issue was closed.
mtklein@google.com changed reviewers: + mtklein@google.com
Message was sent while issue was closed.
Is this the fix for https://luci-milo.appspot.com/swarming/task/313828adc00c8c10/steps/dump_log/0... ? |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
