Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: net/cert/x509_util.cc

Issue 2327973002: Add CertErrors* parameter to the main Certificate parsing functions. (Closed)
Patch Set: nullptr Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/verify_certificate_chain_pkits_unittest.cc ('k') | net/cert/x509_util_openssl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/x509_util.cc
diff --git a/net/cert/x509_util.cc b/net/cert/x509_util.cc
index 8729e560c64aecefb4befcdf59389a99429e5b6d..07065504d49a3b5001086eb468b54bf6ebbd3a21 100644
--- a/net/cert/x509_util.cc
+++ b/net/cert/x509_util.cc
@@ -10,6 +10,7 @@
#include "crypto/ec_private_key.h"
#include "crypto/rsa_private_key.h"
#include "net/base/hash_value.h"
+#include "net/cert/internal/cert_errors.h"
mattm 2016/09/13 22:27:38 unused
eroman 2016/09/13 22:47:30 Done.
#include "net/cert/internal/name_constraints.h"
#include "net/cert/internal/parse_certificate.h"
#include "net/cert/internal/parse_name.h"
@@ -127,7 +128,9 @@ bool ParseCertificateSandboxed(const base::StringPiece& certificate,
der::Input cert_data(certificate);
der::Input tbs_cert, signature_alg;
der::BitString signature_value;
- if (!ParseCertificate(cert_data, &tbs_cert, &signature_alg, &signature_value))
+ CertErrors errors;
mattm 2016/09/13 22:27:38 unused
eroman 2016/09/13 22:47:30 Done.
+ if (!ParseCertificate(cert_data, &tbs_cert, &signature_alg, &signature_value,
+ nullptr))
return false;
ParsedTbsCertificate parsed_tbs_cert;
« no previous file with comments | « net/cert/internal/verify_certificate_chain_pkits_unittest.cc ('k') | net/cert/x509_util_openssl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698