Add CertErrors* parameter to the main Certificate parsing functions.

net/cert/x509_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/x509_util.h"
 
 #include <memory>
 
 #include "base/time/time.h"
 #include "crypto/ec_private_key.h"
 #include "crypto/rsa_private_key.h"
 #include "net/base/hash_value.h"
+#include "net/cert/internal/cert_errors.h"

[mattm, 2016/09/13 22:27:38]

unused

[eroman, 2016/09/13 22:47:30]

Done.

 #include "net/cert/internal/name_constraints.h"
 #include "net/cert/internal/parse_certificate.h"
 #include "net/cert/internal/parse_name.h"
 #include "net/cert/internal/signature_algorithm.h"
 #include "net/cert/x509_certificate.h"
 #include "net/der/input.h"
 #include "net/der/parse_values.h"
 
 namespace net {
 
@@ skipping 97 matching lines @@
 bool ParseCertificateSandboxed(const base::StringPiece& certificate,
                                std::string* subject,
                                std::string* issuer,
                                base::Time* not_before,
                                base::Time* not_after,
                                std::vector<std::string>* dns_names,
                                std::vector<std::string>* ip_addresses) {
   der::Input cert_data(certificate);
   der::Input tbs_cert, signature_alg;
   der::BitString signature_value;
-  if (!ParseCertificate(cert_data, &tbs_cert, &signature_alg, &signature_value))
+  CertErrors errors;

[mattm, 2016/09/13 22:27:38]

unused

[eroman, 2016/09/13 22:47:30]

Done.

+  if (!ParseCertificate(cert_data, &tbs_cert, &signature_alg, &signature_value,
+                        nullptr))
     return false;
 
   ParsedTbsCertificate parsed_tbs_cert;
   if (!ParseTbsCertificate(tbs_cert, ParseCertificateOptions(),
                            &parsed_tbs_cert))
     return false;
 
   if (!GetCommonName(parsed_tbs_cert.subject_tlv, subject))
     return false;
 
@@ skipping 24 matching lines @@
         ip_addresses->push_back(ip.ToString());
     }
   }
 
   return true;
 }
 
 }  // namespace x509_util
 
 }  // namespace net