Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: net/cert/internal/parse_certificate_unittest.cc

Issue 2327973002: Add CertErrors* parameter to the main Certificate parsing functions. (Closed)
Patch Set: StringPiece is kind of dangerous... Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/parse_certificate_fuzzer.cc ('k') | net/cert/internal/parse_ocsp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/parse_certificate_unittest.cc
diff --git a/net/cert/internal/parse_certificate_unittest.cc b/net/cert/internal/parse_certificate_unittest.cc
index 474ab6d2a4b76a67f26abbe99f420cc3ebf78bdd..4b14832652b109c942eb3312ce057874d47d5f3a 100644
--- a/net/cert/internal/parse_certificate_unittest.cc
+++ b/net/cert/internal/parse_certificate_unittest.cc
@@ -5,6 +5,7 @@
#include "net/cert/internal/parse_certificate.h"
#include "base/strings/stringprintf.h"
+#include "net/cert/internal/cert_errors.h"
#include "net/cert/internal/test_helpers.h"
#include "net/der/input.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -49,7 +50,8 @@ void EnsureParsingCertificateSucceeds(const std::string& file_name) {
der::Input signature_algorithm_tlv;
der::BitString signature_value;
ASSERT_TRUE(ParseCertificate(der::Input(&data), &tbs_certificate_tlv,
- &signature_algorithm_tlv, &signature_value));
+ &signature_algorithm_tlv, &signature_value,
+ nullptr));
// Ensure that the parsed certificate matches expectations.
EXPECT_EQ(0, signature_value.unused_bits());
@@ -73,8 +75,12 @@ void EnsureParsingCertificateFails(const std::string& file_name) {
der::Input tbs_certificate_tlv;
der::Input signature_algorithm_tlv;
der::BitString signature_value;
+ CertErrors errors;
ASSERT_FALSE(ParseCertificate(der::Input(&data), &tbs_certificate_tlv,
- &signature_algorithm_tlv, &signature_value));
+ &signature_algorithm_tlv, &signature_value,
+ &errors));
+ // TODO(crbug.com/634443): Verify |errors| to make sure it failed for the
+ // expected reason.
}
// Tests parsing a Certificate.
« no previous file with comments | « net/cert/internal/parse_certificate_fuzzer.cc ('k') | net/cert/internal/parse_ocsp_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698