Add CertErrors* parameter to the main Certificate parsing functions.

net/cert/internal/parse_certificate_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/parse_certificate.h"
 
 #include "base/strings/stringprintf.h"
+#include "net/cert/internal/cert_errors.h"
 #include "net/cert/internal/test_helpers.h"
 #include "net/der/input.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
 
 // Pretty-prints a GeneralizedTime as a human-readable string for use in test
 // expectations (it is more readable to specify the expected results as a
@@ skipping 24 matching lines @@
       {"SIGNATURE ALGORITHM", &expected_signature_algorithm},
       {"TBS CERTIFICATE", &expected_tbs_certificate},
   };
   ASSERT_TRUE(ReadTestDataFromPemFile(GetFilePath(file_name), mappings));
 
   // Parsing the certificate should succeed.
   der::Input tbs_certificate_tlv;
   der::Input signature_algorithm_tlv;
   der::BitString signature_value;
   ASSERT_TRUE(ParseCertificate(der::Input(&data), &tbs_certificate_tlv,
-                               &signature_algorithm_tlv, &signature_value));
+                               &signature_algorithm_tlv, &signature_value,
+                               nullptr));
 
   // Ensure that the parsed certificate matches expectations.
   EXPECT_EQ(0, signature_value.unused_bits());
   EXPECT_EQ(der::Input(&expected_signature), signature_value.bytes());
   EXPECT_EQ(der::Input(&expected_signature_algorithm), signature_algorithm_tlv);
   EXPECT_EQ(der::Input(&expected_tbs_certificate), tbs_certificate_tlv);
 }
 
 // Loads certificate data from the PEM file |file_name| and verifies that the
 // Certificate parsing fails.
 void EnsureParsingCertificateFails(const std::string& file_name) {
   std::string data;
 
   const PemBlockMapping mappings[] = {
       {"CERTIFICATE", &data},
   };
 
   ASSERT_TRUE(ReadTestDataFromPemFile(GetFilePath(file_name), mappings));
 
   // Parsing the Certificate should fail.
   der::Input tbs_certificate_tlv;
   der::Input signature_algorithm_tlv;
   der::BitString signature_value;
+  CertErrors errors;
   ASSERT_FALSE(ParseCertificate(der::Input(&data), &tbs_certificate_tlv,
-                                &signature_algorithm_tlv, &signature_value));
+                                &signature_algorithm_tlv, &signature_value,
+                                &errors));
+  // TODO(crbug.com/634443): Verify |errors| to make sure it failed for the
+  //                         expected reason.
 }
 
 // Tests parsing a Certificate.
 TEST(ParseCertificateTest, Version3) {
   EnsureParsingCertificateSucceeds("cert_version3.pem");
 }
 
 // Tests parsing a simplified Certificate-like structure (the sub-fields for
 // algorithm and tbsCertificate are not actually valid, but ParseCertificate()
 // doesn't check them)
@@ skipping 698 matching lines @@
       0x00,        // Number of unused bits
   };
 
   der::BitString key_usage;
   ASSERT_FALSE(ParseKeyUsage(der::Input(der), &key_usage));
 }
 
 }  // namespace
 
 }  // namespace net