Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2327923002: Revert of Remove obsolete QUIC disabling code. (Closed)

Created:
4 years, 3 months ago by dmurph
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, arv+watch_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove obsolete QUIC disabling code. (patchset #4 id:60001 of https://codereview.chromium.org/2318053004/ ) Reason for revert: test build broken on Android BUG=645623 Original issue's description: > Remove obsolete QUIC disabling code. > > No longer disable QUIC based on public resets post handshake or packet loss during the handshake. Also remove the "k of n" tracking and per-port disablement. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/1c1aa05eaa6b2a04c51e175ed76b5c6f810ff0aa > Cr-Commit-Position: refs/heads/master@{#417677} TBR=eroman@chromium.org,ckrasic@chromium.org,ianswett@chromium.org,rch@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca Cr-Commit-Position: refs/heads/master@{#417694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1410 lines, -57 lines) Patch
M chrome/browser/resources/net_internals/quic_view.html View 1 chunk +1 line, -1 line 0 comments Download
M components/network_session_configurator/network_session_configurator.cc View 2 chunks +30 lines, -0 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 2 chunks +9 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 6 chunks +20 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M net/log/bounded_file_net_log_observer_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_session.h View 3 chunks +15 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 4 chunks +6 lines, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 6 chunks +56 lines, -8 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 8 chunks +186 lines, -13 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 10 chunks +950 lines, -23 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.h View 2 chunks +8 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 2 chunks +19 lines, -2 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dmurph
Created Revert of Remove obsolete QUIC disabling code.
4 years, 3 months ago (2016-09-09 20:36:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327923002/1
4 years, 3 months ago (2016-09-09 20:36:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 20:39:27 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 20:41:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44ca4f4d5bb2d1cdd52b17be2cdc37b7ffc052ca
Cr-Commit-Position: refs/heads/master@{#417694}

Powered by Google App Engine
This is Rietveld 408576698