Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2327923002: Revert of Remove obsolete QUIC disabling code. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index 5a23dffb658bc5ec7edec83b27d27c147bbdef5d..74e834489ffe4d5ce1e22048ca0e4fbeb7b59f13 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -74,6 +74,8 @@
EXPECT_FALSE(params_.quic_disable_disk_cache);
EXPECT_FALSE(params_.quic_prefer_aes);
EXPECT_TRUE(params_.enable_quic_alternative_service_with_different_host);
+ EXPECT_EQ(0, params_.quic_max_number_of_lossy_connections);
+ EXPECT_EQ(1.0f, params_.quic_packet_loss_threshold);
EXPECT_TRUE(params_.quic_delay_tcp_race);
EXPECT_FALSE(params_.quic_close_sessions_on_ip_change);
EXPECT_EQ(net::kIdleConnectionTimeoutSeconds,
@@ -385,6 +387,30 @@
EXPECT_TRUE(params_.enable_quic_alternative_service_with_different_host);
}
+TEST_F(NetworkSessionConfiguratorTest,
+ QuicMaxNumberOfLossyConnectionsFieldTrialParams) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["max_number_of_lossy_connections"] = "5";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_EQ(5, params_.quic_max_number_of_lossy_connections);
+}
+
+TEST_F(NetworkSessionConfiguratorTest,
+ QuicPacketLossThresholdFieldTrialParams) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["packet_loss_threshold"] = "0.5";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_EQ(0.5f, params_.quic_packet_loss_threshold);
+}
+
TEST_F(NetworkSessionConfiguratorTest, QuicReceiveBufferSize) {
std::map<std::string, std::string> field_trial_params;
field_trial_params["receive_buffer_size"] = "2097152";
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698