Address HandlerLeak lint warnings.

Address HandlerLeak lint warnings.

Updated several Handler instances to use static inner classes with
WeakReferences to the outer class to avoid memory leaks. Created
TidyHandler to make this cleaner.

BUG=635567
Committed: https://crrev.com/69affba419bbaf5d66355d0526e1bf6830e60288
Cr-Commit-Position: refs/heads/master@{#420619}

[estevenson, 2016-09-09 16:13:19]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 16:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estevenson, 2016-09-09 17:18:55]

estevenson@chromium.org changed reviewers:
+ tedchoc@chromium.org

[estevenson, 2016-09-09 17:18:56]

ptal Ted, this CL addresses several HandlerLeak lint warnings.

[Ted C, 2016-09-13 17:25:55]

https://codereview.chromium.org/2327833002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/TidyHandler.java
(right):

https://codereview.chromium.org/2327833002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/TidyHandler.java:40: private
WeakReference<T> mClassReference;
For the places that use this, do we actually have destroy call paths that we
could hook into?

I know Tab in particular has destroy(), and it seems like we could instead call
https://developer.android.com/reference/android/os/Handler.html#removeCallbac...
w/ null and remove any pending callbacks and then we're not relying on weak
references to clean this up.

"Ideally" we just introduce a more consistent policy of cleaning up your
handlers instead of weak refs, but that might not always be possible.  I just
think we should explore that option first.  We'd still need to add FindBugs
exclusions, but that seems "more correct" in terms of logic.

If we do need this, I wonder if we could introduce an interface

interface MessageHandler {
    void handleMessage(Message m);
}

Then instead of taking a <T>, this could just take the MessageHandler interface
and clean that up a bit.

For example, Tab would just implement the interface at the top level and then
could create a new TidyHandler(this) to reduce the inner class fun.

[estevenson, 2016-09-22 22:40:19]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 22:41:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:45:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:45:32]

Dry run: This issue passed the CQ dry run.

[estevenson, 2016-09-23 00:52:51]

ptal Ted, sorry for the delay.

[Ted C, 2016-09-23 01:01:18]

lgtm (w/ update change comment)

https://codereview.chromium.org/2327833002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
(right):

https://codereview.chromium.org/2327833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java:223:
public void cleanupHandler() {
i would call this destroy to be consistent.  this expose a "bit" too much info
to the caller imo.  to the caller, having an opaque clean up your stuff method
is best

[estevenson, 2016-09-23 01:25:40]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2016-09-23 01:25:40]

+agrieve for suppressions.xml OWNERS

https://codereview.chromium.org/2327833002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
(right):

https://codereview.chromium.org/2327833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java:223:
public void cleanupHandler() {
On 2016/09/23 01:01:18, Ted C wrote:
> i would call this destroy to be consistent.  this expose a "bit" too much info
> to the caller imo.  to the caller, having an opaque clean up your stuff method
> is best

Done.

[agrieve, 2016-09-23 01:48:28]

On 2016/09/23 01:25:40, estevenson wrote:
> +agrieve for suppressions.xml OWNERS
> 
>
https://codereview.chromium.org/2327833002/diff/40001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
> (right):
> 
>
https://codereview.chromium.org/2327833002/diff/40001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java:223:
> public void cleanupHandler() {
> On 2016/09/23 01:01:18, Ted C wrote:
> > i would call this destroy to be consistent.  this expose a "bit" too much
info
> > to the caller imo.  to the caller, having an opaque clean up your stuff
method
> > is best
> 
> Done.

lgtm

[estevenson, 2016-09-23 14:53:58]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2016-09-23 14:53:58]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2327833002/#ps60001
(title: "tedchoc's comment")

[commit-bot: I haz the power, 2016-09-23 14:54:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 16:26:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-23 16:29:54]

Description was changed from

==========
Address HandlerLeak lint warnings.

Updated several Handler instances to use static inner classes with
WeakReferences to the outer class to avoid memory leaks. Created
TidyHandler to make this cleaner.

BUG=635567
==========

to

==========
Address HandlerLeak lint warnings.

Updated several Handler instances to use static inner classes with
WeakReferences to the outer class to avoid memory leaks. Created
TidyHandler to make this cleaner.

BUG=635567

Committed: https://crrev.com/69affba419bbaf5d66355d0526e1bf6830e60288
Cr-Commit-Position: refs/heads/master@{#420619}
==========

[commit-bot: I haz the power, 2016-09-23 16:29:55]

Patchset 4 (id:??) landed as
https://crrev.com/69affba419bbaf5d66355d0526e1bf6830e60288
Cr-Commit-Position: refs/heads/master@{#420619}