Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4891)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2327833002: Address HandlerLeak lint warnings. (Closed)
Patch Set: tedchoc's comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index d9bb97af26b99c2264f8b5d2655cb0f58ed07cc3..f694cb5c57dc23ae15d56a78277eccdfb69625f6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.tab;
+import android.annotation.SuppressLint;
import android.app.Activity;
import android.app.Application;
import android.content.Context;
@@ -623,6 +624,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
* accounting. When null, TabUma will not be initialized.
* @param frozenState State containing information about this Tab, if it was persisted.
*/
+ @SuppressLint("HandlerLeak")
public Tab(int id, int parentId, boolean incognito, Context context,
WindowAndroid window, TabLaunchType type, TabCreationState creationState,
TabState frozenState) {
@@ -2103,6 +2105,9 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
mPreviousFullscreenContentOffsetY = Float.NaN;
mNeedsReload = false;
+
+ // Remove pending handler actions to prevent memory leaks.
+ mHandler.removeCallbacksAndMessages(null);
}
/**
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698