Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 2327743002: Rename Node::shadowHost() to Node::ownerShadowHost() (Closed)

Created:
4 years, 3 months ago by hayato
Modified:
4 years, 3 months ago
Reviewers:
tkent, kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dcheng, dglazkov+blink, dshwang, krit, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, f(malita), fs, gasubic, gyuyoung2, jchaffraix+rendering, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, sof, nessy, slimming-paint-reviews_chromium.org, Srirama, szager+layoutwatch_chromium.org, vcarbune.chromium, webcomponents-bugzilla_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Node::shadowHost() to Node::ownerShadowHost() I think Node::shadowHost() is not a good name because it is unclear *which* shadowHost would be returned by its name. Node::ownerShadowHost() might be a better name than Node::shadowHost(). It is similar to Node::ownerDocument(), where it is clear that the owner would be returned. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/9a2cefc4c20b11f7995c59a910c858a4c5732e7d Cr-Commit-Position: refs/heads/master@{#417555}

Patch Set 1 #

Patch Set 2 : fix ThemePainerMac.mm #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -74 lines) Patch
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/InsertionPoint.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventPath.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/DetailsMarkerControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/ProgressShadowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SpinButtonElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (20 generated)
hayato
PTAL
4 years, 3 months ago (2016-09-09 04:25:38 UTC) #6
kochi
lgtm Mac build failing, maybe you forgot to update third_party/WebKit/Source/core/paint/paint/ThemePainterMac.cpp?
4 years, 3 months ago (2016-09-09 05:41:57 UTC) #9
hayato
fix ThemePainerMac.mm
4 years, 3 months ago (2016-09-09 06:11:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327743002/20001
4 years, 3 months ago (2016-09-09 06:12:19 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/256319)
4 years, 3 months ago (2016-09-09 06:15:47 UTC) #19
tkent
lgtm
4 years, 3 months ago (2016-09-09 06:30:48 UTC) #20
hayato
fix
4 years, 3 months ago (2016-09-09 09:19:37 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327743002/40001
4 years, 3 months ago (2016-09-09 09:20:14 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-09 11:09:07 UTC) #28
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 11:11:04 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9a2cefc4c20b11f7995c59a910c858a4c5732e7d
Cr-Commit-Position: refs/heads/master@{#417555}

Powered by Google App Engine
This is Rietveld 408576698