third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp - Issue 2327743002: Rename Node::shadowHost() to Node::ownerShadowHost()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

Issue 2327743002: Rename Node::shadowHost() to Node::ownerShadowHost() (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp ('k') | third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

index 1d64b3d7c29eb0313511f84df2910aab05aceebc..9a96b4a188a4ead9bf3468237d20040b6bae3411 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

@@ -375,8 +375,8 @@ bool HTMLTextFormControlElement::setSelectionRange(int start, int end, TextField

// startPosition and endPosition can be null position for example when

// "-webkit-user-select: none" style attribute is specified.

if (startPosition.isNotNull() && endPosition.isNotNull()) {

- DCHECK_EQ(startPosition.anchorNode()->shadowHost(), this);

- DCHECK_EQ(endPosition.anchorNode()->shadowHost(), this);

+ DCHECK_EQ(startPosition.anchorNode()->ownerShadowHost(), this);

+ DCHECK_EQ(endPosition.anchorNode()->ownerShadowHost(), this);

}

#endif // DCHECK_IS_ON()

VisibleSelection newSelection;

@@ -751,7 +751,7 @@ String HTMLTextFormControlElement::valueWithHardLineBreaks() const

HTMLTextFormControlElement* enclosingTextFormControl(const Position& position)

{

DCHECK(position.isNull() || position.isOffsetInAnchor()

- || position.computeContainerNode() || !position.anchorNode()->shadowHost()

+ || position.computeContainerNode() || !position.anchorNode()->ownerShadowHost()

|| (position.anchorNode()->parentNode() && position.anchorNode()->parentNode()->isShadowRoot()));

return enclosingTextFormControl(position.computeContainerNode());

}

@@ -760,7 +760,7 @@ HTMLTextFormControlElement* enclosingTextFormControl(Node* container)

{

if (!container)

return nullptr;

- Element* ancestor = container->shadowHost();

+ Element* ancestor = container->ownerShadowHost();

return ancestor && isHTMLTextFormControlElement(*ancestor) && container->containingShadowRoot()->type() == ShadowRootType::UserAgent ? toHTMLTextFormControlElement(ancestor) : 0;

}