Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 232773011: Zoom Extension API (work in progress) (Closed)

Created:
6 years, 8 months ago by paulmeyer
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Visibility:
Public.

Description

Implementation of a Zoom Extension API as an addition to the chrome.tabs API, as outlined in https://docs.google.com/a/chromium.org/document/d/1sCZjx1J3_M2a02T8NXd-ufGKZDoBHI5Ixis1DaGLQCA/edit?usp=sharing. Grabbed all the chrome/ changes from https://codereview.chromium.org/225093019/, and then reimplemented all the functionality that was lost from taking callbacks, zoom modes, and the WebContentsObserver additions out of content/. BUG=30583

Patch Set 1 #

Patch Set 2 : Took callbacks, zoom modes, and observer stuff out of content, and reimplemented similar functional… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1050 lines, -31 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chrome_page_zoom.cc View 1 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.h View 1 3 chunks +53 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 4 chunks +172 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_constants.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_constants.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_event_router.h View 1 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_event_router.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 2 chunks +233 lines, -0 lines 0 comments Download
M chrome/browser/guestview/webview/webview_guest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.h View 5 chunks +37 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 1 10 chunks +99 lines, -11 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.h View 1 5 chunks +60 lines, -1 line 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.cc View 1 5 chunks +134 lines, -8 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_observer.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/tabs.json View 3 chunks +153 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/tabs/basics/events.js View 1 chunk +17 lines, -1 line 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
paulmeyer
6 years, 8 months ago (2014-04-12 03:57:57 UTC) #1
raymes
Any update on this? Thanks!
6 years, 7 months ago (2014-05-08 06:27:04 UTC) #2
raymes
Friendly ping. Fady, do you have any idea on the status of this? Thanks! Raymes ...
6 years, 7 months ago (2014-05-14 07:29:09 UTC) #3
Fady Samuel
Hi Raymes, This is still being worked on. James is familiarizing himself with Paul's code, ...
6 years, 7 months ago (2014-05-14 11:00:10 UTC) #4
raymes
Thanks Fady. What do you think the timeline will be on this? We would like ...
6 years, 7 months ago (2014-05-15 22:53:47 UTC) #5
Fady Samuel
Looks like there's a lot of complexity in getting zoom to do the right thing ...
6 years, 7 months ago (2014-05-15 22:57:11 UTC) #6
raymes
Thanks! That would be great. Raymes On Fri, May 16, 2014 at 8:57 AM, Fady ...
6 years, 7 months ago (2014-05-16 00:49:47 UTC) #7
wjmaclean
6 years, 6 months ago (2014-05-28 15:25:50 UTC) #8
Closing, and moving review to https://codereview.chromium.org/301733006/

Powered by Google App Engine
This is Rietveld 408576698