Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: ui/base/clipboard/clipboard_unittest.cc

Issue 232773008: More removal of GTK code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/clipboard/clipboard_unittest.cc
diff --git a/ui/base/clipboard/clipboard_unittest.cc b/ui/base/clipboard/clipboard_unittest.cc
index 30798d39de9c2ffc9076222a16eadaf4e43a7de1..d28720bd97d437f3d438990e5cb90619522cad81 100644
--- a/ui/base/clipboard/clipboard_unittest.cc
+++ b/ui/base/clipboard/clipboard_unittest.cc
@@ -159,49 +159,6 @@ TEST_F(ClipboardTest, RTFTest) {
EXPECT_EQ(rtf, result);
}
-#if defined(TOOLKIT_GTK)
-TEST_F(ClipboardTest, MultipleBufferTest) {
- base::string16 text(ASCIIToUTF16("Standard")), text_result;
- base::string16 markup(ASCIIToUTF16("<string>Selection</string>"));
- std::string url("http://www.example.com/"), url_result;
-
- {
- ScopedClipboardWriter clipboard_writer(&clipboard(),
- CLIPBOARD_TYPE_COPY_PASTE);
- clipboard_writer.WriteText(text);
- }
-
- {
- ScopedClipboardWriter clipboard_writer(&clipboard(),
- CLIPBOARD_TYPE_SELECTION);
- clipboard_writer.WriteHTML(markup, url);
- }
-
- EXPECT_TRUE(clipboard().IsFormatAvailable(Clipboard::GetPlainTextFormatType(),
- CLIPBOARD_TYPE_COPY_PASTE));
- EXPECT_FALSE(clipboard().IsFormatAvailable(
- Clipboard::GetPlainTextFormatType(),
- CLIPBOARD_TYPE_SELECTION));
-
- EXPECT_FALSE(clipboard().IsFormatAvailable(Clipboard::GetHtmlFormatType(),
- CLIPBOARD_TYPE_COPY_PASTE));
- EXPECT_TRUE(clipboard().IsFormatAvailable(Clipboard::GetHtmlFormatType(),
- CLIPBOARD_TYPE_SELECTION));
-
- clipboard().ReadText(CLIPBOARD_TYPE_COPY_PASTE, &text_result);
- EXPECT_EQ(text, text_result);
-
- uint32 ignored;
- base::string16 markup_result;
- clipboard().ReadHTML(CLIPBOARD_TYPE_SELECTION,
- &markup_result,
- &url_result,
- &ignored,
- &ignored);
- EXPECT_PRED2(MarkupMatches, markup, markup_result);
-}
-#endif
-
TEST_F(ClipboardTest, TrickyHTMLTest) {
base::string16 markup(ASCIIToUTF16("<em>Bye!<!--EndFragment --></em>")),
markup_result;
@@ -254,27 +211,6 @@ TEST_F(ClipboardTest, UniodeHTMLTest) {
}
#endif // defined(OS_WIN)
-#if defined(TOOLKIT_GTK)
-// Regression test for crbug.com/56298 (pasting empty HTML crashes Linux).
-TEST_F(ClipboardTest, EmptyHTMLTest) {
- // ScopedClipboardWriter doesn't let us write empty data to the clipboard.
- clipboard().clipboard_data_ = new Clipboard::TargetMap();
- // The 1 is so the compiler doesn't warn about allocating an empty array.
- char* empty = new char[1];
- clipboard().InsertMapping("text/html", empty, 0U);
- clipboard().SetGtkClipboard(CLIPBOARD_TYPE_COPY_PASTE);
-
- EXPECT_TRUE(clipboard().IsFormatAvailable(Clipboard::GetHtmlFormatType(),
- CLIPBOARD_TYPE_COPY_PASTE));
- base::string16 markup_result;
- std::string url_result;
- uint32 ignored;
- clipboard().ReadHTML(CLIPBOARD_TYPE_COPY_PASTE, &markup_result, &url_result,
- &ignored, &ignored);
- EXPECT_PRED2(MarkupMatches, base::string16(), markup_result);
-}
-#endif
-
// TODO(estade): Port the following test (decide what target we use for urls)
#if !defined(OS_POSIX) || defined(OS_MACOSX)
TEST_F(ClipboardTest, BookmarkTest) {
@@ -414,19 +350,8 @@ static void TestBitmapWrite(Clipboard* clipboard,
for (int i = 0; i < image.width(); ++i) {
int offset = i + j * image.width();
uint32 pixel = SkPreMultiplyColor(bitmap_data[offset]);
-#if defined(TOOLKIT_GTK)
- // Non-Aura GTK doesn't support alpha transparency. Instead, the alpha
- // channel is always set to 0xFF - see http://crbug.com/154573.
- // However, since we premultiplied above, we must also premultiply here
- // before unpremultiplying and setting alpha to 0xFF; otherwise, the
- // results will not match GTK's.
- EXPECT_EQ(
- SkUnPreMultiply::PMColorToColor(pixel) | 0xFF000000, row_address[i])
- << "i = " << i << ", j = " << j;
-#else
EXPECT_EQ(pixel, row_address[i])
<< "i = " << i << ", j = " << j;
-#endif // defined(TOOLKIT_GTK)
}
}
}

Powered by Google App Engine
This is Rietveld 408576698