Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 232773008: More removal of GTK code. (Closed)

Created:
6 years, 8 months ago by Elliot Glaysher
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, derat+watch_chromium.org, vandebo (ex-Chrome), Lei Zhang, tfarina, dcheng, tommycli, rsesek+watch_chromium.org, Greg Billock, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : thestig nits #

Total comments: 3

Patch Set 3 : Even more #

Patch Set 4 : Rebase to tot #

Patch Set 5 : Remove base/ so I don't need another stamp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -715 lines) Patch
M apps/app_window_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M apps/ui/web_contents_sizer.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/background/background_contents_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/defaults.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/defaults.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 2 3 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/prefs/pref_service_browsertest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_unittest_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_tab_helper.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_tab_helper.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/common/localized_error.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/base/interactive_test_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M ppapi/proxy/serialized_structs.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/base/accelerators/accelerator.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M ui/base/clipboard/clipboard.h View 4 chunks +0 lines, -37 lines 0 comments Download
M ui/base/clipboard/clipboard_unittest.cc View 1 2 3 chunks +1 line, -33 lines 0 comments Download
M ui/base/clipboard/custom_data_helper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/custom_data_helper_linux.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
D ui/gfx/image/cairo_cached_surface.h View 1 chunk +0 lines, -84 lines 0 comments Download
D ui/gfx/image/cairo_cached_surface.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M ui/gfx/image/image.h View 4 chunks +3 lines, -15 lines 0 comments Download
M ui/gfx/platform_font_pango.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M ui/gl/gl_surface_glx.h View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
M ui/gl/gl_surface_glx.cc View 6 chunks +0 lines, -173 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/surface/transport_dib.h View 3 chunks +1 line, -52 lines 0 comments Download
M ui/surface/transport_dib_posix.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Elliot Glaysher
6 years, 8 months ago (2014-04-11 17:49:56 UTC) #1
Lei Zhang
chrome/ lgtm with one additional edit below https://codereview.chromium.org/232773008/diff/1/chrome/browser/defaults.cc File chrome/browser/defaults.cc (right): https://codereview.chromium.org/232773008/diff/1/chrome/browser/defaults.cc#newcode52 chrome/browser/defaults.cc:52: const bool ...
6 years, 8 months ago (2014-04-11 20:52:10 UTC) #2
Lei Zhang
https://codereview.chromium.org/232773008/diff/1/apps/app_window_browsertest.cc File apps/app_window_browsertest.cc (right): https://codereview.chromium.org/232773008/diff/1/apps/app_window_browsertest.cc#newcode19 apps/app_window_browsertest.cc:19: #if (defined(OS_LINUX) && !defined(OS_CHROMEOS)) nit: Remove extra parenthesis. Ditto ...
6 years, 8 months ago (2014-04-11 21:07:04 UTC) #3
Elliot Glaysher
Adding piman https://codereview.chromium.org/232773008/diff/1/ui/base/clipboard/clipboard.h File ui/base/clipboard/clipboard.h (right): https://codereview.chromium.org/232773008/diff/1/ui/base/clipboard/clipboard.h#newcode8 ui/base/clipboard/clipboard.h:8: #include <map> On 2014/04/11 21:07:04, Lei Zhang ...
6 years, 8 months ago (2014-04-11 21:28:16 UTC) #4
piman
lgtm
6 years, 8 months ago (2014-04-11 21:38:59 UTC) #5
piman
https://codereview.chromium.org/232773008/diff/10001/ui/gl/gl_surface_glx.cc File ui/gl/gl_surface_glx.cc (left): https://codereview.chromium.org/232773008/diff/10001/ui/gl/gl_surface_glx.cc#oldcode699 ui/gl/gl_surface_glx.cc:699: #endif nit: actually, don't you want to remove these ...
6 years, 8 months ago (2014-04-11 21:40:31 UTC) #6
dcheng
https://codereview.chromium.org/232773008/diff/10001/ui/base/clipboard/clipboard_unittest.cc File ui/base/clipboard/clipboard_unittest.cc (left): https://codereview.chromium.org/232773008/diff/10001/ui/base/clipboard/clipboard_unittest.cc#oldcode162 ui/base/clipboard/clipboard_unittest.cc:162: #if defined(TOOLKIT_GTK) Shouldn't this test run on Linux Aura?
6 years, 8 months ago (2014-04-11 21:49:49 UTC) #7
Elliot Glaysher
+yoz for I don't know. dcheng: readded test. Now going through trybots; passed locally. https://codereview.chromium.org/232773008/diff/10001/ui/base/clipboard/clipboard_unittest.cc ...
6 years, 8 months ago (2014-04-11 22:16:43 UTC) #8
Yoyo Zhou
LGTM for I don't know either (actually I assume it's for chrome/browser/extensions)
6 years, 8 months ago (2014-04-11 22:19:46 UTC) #9
sky
LGTM
6 years, 8 months ago (2014-04-14 14:41:32 UTC) #10
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 8 months ago (2014-04-14 18:10:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/232773008/50001
6 years, 8 months ago (2014-04-14 18:10:18 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 18:50:22 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61222
6 years, 8 months ago (2014-04-14 18:50:22 UTC) #14
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 8 months ago (2014-04-14 19:17:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/232773008/70001
6 years, 8 months ago (2014-04-14 19:17:55 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 00:45:31 UTC) #17
Message was sent while issue was closed. 
Change committed as 263757

Powered by Google App Engine
This is Rietveld 408576698