Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_apitest.cc

Issue 232773008: More removal of GTK code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_window/app_window_apitest.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_apitest.cc b/chrome/browser/extensions/api/app_window/app_window_apitest.cc
index 5866c19461244bf79c87fccab5e478e0d6bd07e7..77a101bf6f7cdee706fbfc079c698a7fd71c8763 100644
--- a/chrome/browser/extensions/api/app_window/app_window_apitest.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_apitest.cc
@@ -15,10 +15,6 @@
#include "ui/base/base_window.h"
#include "ui/gfx/rect.h"
-#ifdef TOOLKIT_GTK
-#include "content/public/test/test_utils.h"
-#endif
-
using apps::AppWindow;
namespace {
@@ -68,33 +64,9 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, DISABLED_WindowsApiBounds) {
new_bounds.Inset(-window->GetBaseWindow()->GetFrameInsets());
window->GetBaseWindow()->SetBounds(new_bounds);
- // TODO(jeremya/asargent) figure out why in GTK the window doesn't end up
-// with exactly the bounds we set. Is it a bug in our app window
-// implementation? crbug.com/160252
-#ifdef TOOLKIT_GTK
- int slop = 50;
-#else
int slop = 0;
-#endif // !TOOLKIT_GTK
-
ready_listener.Reply(base::IntToString(slop));
-#ifdef TOOLKIT_GTK
- // TODO(asargent)- this is here to help track down the root cause of
- // crbug.com/164735.
- {
- gfx::Rect last_bounds;
- while (!success_listener.was_satisfied()) {
- gfx::Rect current_bounds = window->GetBaseWindow()->GetBounds();
- if (current_bounds != last_bounds) {
- LOG(INFO) << "new bounds: " << current_bounds.ToString();
- }
- last_bounds = current_bounds;
- content::RunAllPendingInMessageLoop();
- }
- }
-#endif
-
ASSERT_TRUE(success_listener.WaitUntilSatisfied());
}

Powered by Google App Engine
This is Rietveld 408576698