Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: apps/app_window_browsertest.cc

Issue 232773008: More removal of GTK code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove base/ so I don't need another stamp. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | apps/ui/web_contents_sizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/ui/native_app_window.h" 5 #include "apps/ui/native_app_window.h"
6 #include "chrome/browser/apps/app_browsertest_util.h" 6 #include "chrome/browser/apps/app_browsertest_util.h"
7 7
8 using extensions::Extension; 8 using extensions::Extension;
9 9
10 namespace apps { 10 namespace apps {
11 11
12 namespace { 12 namespace {
13 13
14 typedef extensions::PlatformAppBrowserTest AppWindowBrowserTest; 14 typedef extensions::PlatformAppBrowserTest AppWindowBrowserTest;
15 15
16 // This test is disabled on Linux because of the unpredictable nature of native 16 // This test is disabled on Linux because of the unpredictable nature of native
17 // windows. We cannot assume that the window manager will insert any title bar 17 // windows. We cannot assume that the window manager will insert any title bar
18 // at all, so the test may fail on certain window managers. 18 // at all, so the test may fail on certain window managers.
19 #if defined(TOOLKIT_GTK) || (defined(OS_LINUX) && !defined(OS_CHROMEOS)) 19 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
20 #define MAYBE_FrameInsetsForDefaultFrame DISABLED_FrameInsetsForDefaultFrame 20 #define MAYBE_FrameInsetsForDefaultFrame DISABLED_FrameInsetsForDefaultFrame
21 #else 21 #else
22 #define MAYBE_FrameInsetsForDefaultFrame FrameInsetsForDefaultFrame 22 #define MAYBE_FrameInsetsForDefaultFrame FrameInsetsForDefaultFrame
23 #endif 23 #endif
24 24
25 // Verifies that the NativeAppWindows implement GetFrameInsets() correctly. 25 // Verifies that the NativeAppWindows implement GetFrameInsets() correctly.
26 // See http://crbug.com/346115 26 // See http://crbug.com/346115
27 IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) { 27 IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForDefaultFrame) {
28 AppWindow* app_window = CreateTestAppWindow("{}"); 28 AppWindow* app_window = CreateTestAppWindow("{}");
29 NativeAppWindow* native_window = app_window->GetBaseWindow(); 29 NativeAppWindow* native_window = app_window->GetBaseWindow();
30 gfx::Insets insets = native_window->GetFrameInsets(); 30 gfx::Insets insets = native_window->GetFrameInsets();
31 31
32 // It is a reasonable assumption that the top padding must be greater than 32 // It is a reasonable assumption that the top padding must be greater than
33 // the bottom padding due to the title bar. 33 // the bottom padding due to the title bar.
34 EXPECT_GT(insets.top(), insets.bottom()); 34 EXPECT_GT(insets.top(), insets.bottom());
35 35
36 CloseAppWindow(app_window); 36 CloseAppWindow(app_window);
37 } 37 }
38 38
39 // This test is also disabled on Linux because frame: color is ignored on stable 39 // This test is also disabled on Linux because frame: color is ignored on stable
40 // and beta channels (so it can fail the same as the previous test). 40 // and beta channels (so it can fail the same as the previous test).
41 // TODO(benwells): Re-enable on Linux after frame: color is on stable. 41 // TODO(benwells): Re-enable on Linux after frame: color is on stable.
42 #if defined(TOOLKIT_GTK) || (defined(OS_LINUX) && !defined(OS_CHROMEOS)) 42 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
43 #define MAYBE_FrameInsetsForColoredFrame DISABLED_FrameInsetsForColoredFrame 43 #define MAYBE_FrameInsetsForColoredFrame DISABLED_FrameInsetsForColoredFrame
44 #else 44 #else
45 #define MAYBE_FrameInsetsForColoredFrame FrameInsetsForColoredFrame 45 #define MAYBE_FrameInsetsForColoredFrame FrameInsetsForColoredFrame
46 #endif 46 #endif
47 47
48 // Verifies that the NativeAppWindows implement GetFrameInsets() correctly. 48 // Verifies that the NativeAppWindows implement GetFrameInsets() correctly.
49 // See http://crbug.com/346115 49 // See http://crbug.com/346115
50 IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForColoredFrame) { 50 IN_PROC_BROWSER_TEST_F(AppWindowBrowserTest, MAYBE_FrameInsetsForColoredFrame) {
51 AppWindow* app_window = 51 AppWindow* app_window =
52 CreateTestAppWindow("{ \"frame\": { \"color\": \"#ffffff\" } }"); 52 CreateTestAppWindow("{ \"frame\": { \"color\": \"#ffffff\" } }");
(...skipping 19 matching lines...) Expand all
72 EXPECT_EQ(0, insets.bottom()); 72 EXPECT_EQ(0, insets.bottom());
73 EXPECT_EQ(0, insets.left()); 73 EXPECT_EQ(0, insets.left());
74 EXPECT_EQ(0, insets.right()); 74 EXPECT_EQ(0, insets.right());
75 75
76 CloseAppWindow(app_window); 76 CloseAppWindow(app_window);
77 } 77 }
78 78
79 } // namespace 79 } // namespace
80 80
81 } // namespace apps 81 } // namespace apps
OLDNEW
« no previous file with comments | « no previous file | apps/ui/web_contents_sizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698