Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 232773004: gyp: cache conditional ASTs for 3 CPU seconds (5%) gain. (Closed)

Created:
6 years, 8 months ago by Daniel Bratell
Modified:
6 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com, scottmg
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

gyp: cache conditional ASTs for 3 CPU seconds (5%) gain. This is in the parallel part so net gain is somewhere between 5/core_count% and 5%. In chromium on my computer I save roughly 1.5 seconds in total runtime. BUG=362075 r1900

Patch Set 1 #

Patch Set 2 : Fixing error message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -42 lines) Patch
M pylib/gyp/input.py View 1 2 chunks +54 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Bratell
This is one of a series (maybe 15-20 changes in total). They are almost all ...
6 years, 8 months ago (2014-04-10 14:21:57 UTC) #1
scottmg
input.py -> mark
6 years, 8 months ago (2014-04-10 17:14:35 UTC) #2
Daniel Bratell
On 2014/04/10 17:14:35, scottmg wrote: > input.py -> mark I suspect this was a change ...
6 years, 8 months ago (2014-04-11 08:24:37 UTC) #3
Daniel Bratell
mark, can you please take a look? This is one of the bigger improvements, and ...
6 years, 8 months ago (2014-04-14 09:51:22 UTC) #4
Daniel Bratell
I should mention that this patch is smaller than it looks. It's this big because ...
6 years, 8 months ago (2014-04-15 16:14:26 UTC) #5
Mark Mentovai
LGTM
6 years, 8 months ago (2014-04-15 21:49:26 UTC) #6
Nico
6 years, 8 months ago (2014-04-16 15:37:41 UTC) #7
r1900

Powered by Google App Engine
This is Rietveld 408576698