chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java - Issue 2327673002: Mark flaky chrome_public tests with @RetryOnFailure Batch 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java

Issue 2327673002: Mark flaky chrome_public tests with @RetryOnFailure Batch 1 (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java

index 5f53f892b952cef7255e07427500e556caada228..7d1dcbe876c04a3b7feedb38c01bfbc1f0849f25 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java

@@ -10,6 +10,7 @@ import android.test.InstrumentationTestCase;

import android.test.mock.MockPackageManager;

import android.test.suitebuilder.annotation.SmallTest;

+import org.chromium.base.test.util.RetryOnFailure;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

@@ -151,6 +152,7 @@ public class InstallerDelegateTest extends InstrumentationTestCase

* Makes sure that the runnable isn't called until returning from start().

@SmallTest

+ @RetryOnFailure

public void testRunnableRaceCondition() throws InterruptedException {

mPackageManager.isInstalled = true;

mTestDelegate.setTimingForTests(1, 5000);