Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5518)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2327673002: Mark flaky chrome_public tests with @RetryOnFailure Batch 1 (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index 548801cd2dae804f022cdf0d7c6925b673a1b2ec..3b674f3b013aa05e3629a33baa6648a80134959c 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -23,6 +23,7 @@ import android.widget.TextView;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.chrome.browser.infobar.AppBannerInfoBarAndroid;
@@ -333,6 +334,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
@SmallTest
@Feature({"AppBanners"})
+ @RetryOnFailure
public void testFullNativeInstallPathwayFromId() throws Exception {
runFullNativeInstallPathway(mNativeAppUrl, NATIVE_APP_BLANK_REFERRER);
}
@@ -346,6 +348,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
@MediumTest
@Feature({"AppBanners"})
+ @RetryOnFailure
public void testBannerAppearsThenDoesNotAppearAgainForMonths() throws Exception {
// Visit a site that requests a banner.
new TabLoadObserver(getActivity().getActivityTab()).fullyLoadUrl(mNativeAppUrl);
@@ -441,6 +444,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
@MediumTest
@Feature({"AppBanners"})
+ @RetryOnFailure
public void testBitmapFetchersCanOverlapWithoutCrashing() throws Exception {
// Visit a site that requests a banner rapidly and repeatedly.
for (int i = 1; i <= 10; i++) {
@@ -459,12 +463,14 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
@SmallTest
@Feature({"AppBanners"})
+ @RetryOnFailure
public void testWebAppBannerAppears() throws Exception {
triggerWebAppBanner(mWebAppUrl, WEB_APP_TITLE);
}
@SmallTest
@Feature({"AppBanners"})
+ @RetryOnFailure
public void testBannerFallsBackToShortName() throws Exception {
triggerWebAppBanner(mTestServer.getURL(WEB_APP_SHORT_TITLE_PATH), WEB_APP_SHORT_TITLE);
}

Powered by Google App Engine
This is Rietveld 408576698