third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp - Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ASSERT_UNUSED Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/TextTrackLoader.cpp ('K') | « third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp ('k') | third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp

diff --git a/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp b/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp

index 5ad0cb75439cebaf48b0b0ad7f0ad4da15c8e3c1..6cca2812406f0b2694fd6a7745b8c0b1f92a8083 100644

--- a/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp

+++ b/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp

@@ -130,7 +130,7 @@ const AtomicString& ApplicationCache::toEventType(ApplicationCacheHost::EventID

case ApplicationCacheHost::kObsoleteEvent:

return EventTypeNames::obsolete;

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return EventTypeNames::error;

}