Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: third_party/WebKit/Source/core/loader/TextTrackLoader.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ASSERT_UNUSED Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/TextTrackLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp b/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp
index 98629645ff6457d2cc093be05cdea349105f9542..51a42194604047f292e406c908014599935cd15e 100644
--- a/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp
@@ -51,7 +51,8 @@ TextTrackLoader::~TextTrackLoader()
void TextTrackLoader::cueLoadTimerFired(TimerBase* timer)
{
- ASSERT_UNUSED(timer, timer == &m_cueLoadTimer);
+ ALLOW_UNUSED_LOCAL(timer);
yhirano 2016/09/12 04:33:14 ditto as Resource::cancelTimerFired.
hiroshige 2016/09/13 08:43:21 Done.
+ DCHECK(timer == &m_cueLoadTimer);
yhirano 2016/09/12 04:33:14 DCHECK_EQ
hiroshige 2016/09/13 08:43:21 Done.
if (m_newCuesAvailable) {
m_newCuesAvailable = false;
@@ -69,7 +70,7 @@ void TextTrackLoader::cancelLoad()
void TextTrackLoader::dataReceived(Resource* resource, const char* data, size_t length)
{
- ASSERT(this->resource() == resource);
+ DCHECK(this->resource() == resource);
yhirano 2016/09/12 04:33:14 DCHECK_EQ
hiroshige 2016/09/13 08:43:21 Done.
if (m_state == Failed)
return;
@@ -89,7 +90,7 @@ void TextTrackLoader::corsPolicyPreventedLoad(SecurityOrigin* securityOrigin, co
void TextTrackLoader::notifyFinished(Resource* resource)
{
- ASSERT(this->resource() == resource);
+ DCHECK(this->resource() == resource);
yhirano 2016/09/12 04:33:14 DCHECK_EQ
hiroshige 2016/09/13 08:43:21 Done.
if (m_state != Failed)
m_state = resource->errorOccurred() ? Failed : Finished;
@@ -147,14 +148,14 @@ void TextTrackLoader::fileFailedToParse()
void TextTrackLoader::getNewCues(HeapVector<Member<TextTrackCue>>& outputCues)
{
- ASSERT(m_cueParser);
+ DCHECK(m_cueParser);
if (m_cueParser)
m_cueParser->getNewCues(outputCues);
}
void TextTrackLoader::getNewRegions(HeapVector<Member<VTTRegion>>& outputRegions)
{
- ASSERT(m_cueParser);
+ DCHECK(m_cueParser);
if (m_cueParser)
m_cueParser->getNewRegions(outputRegions);
}

Powered by Google App Engine
This is Rietveld 408576698