Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ASSERT_UNUSED Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
diff --git a/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp b/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
index caadc1d5043c2f8fe07b0fff9c2b66f03b6c7b7f..4703dc98d4d337266192babda771be82c9bd7e58 100644
--- a/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
+++ b/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
@@ -294,7 +294,7 @@ private:
: ScheduledNavigation(0, document, replacesCurrentItem, true)
, m_submission(submission)
{
- ASSERT(m_submission->form());
+ DCHECK(m_submission->form());
}
Member<FormSubmission> m_submission;
@@ -409,14 +409,14 @@ void NavigationScheduler::scheduleLocationChange(Document* originDocument, const
void NavigationScheduler::schedulePageBlock(Document* originDocument)
{
- ASSERT(m_frame->page());
+ DCHECK(m_frame->page());
const KURL& url = m_frame->document()->url();
schedule(ScheduledPageBlock::create(originDocument, url));
}
void NavigationScheduler::scheduleFormSubmission(Document* document, FormSubmission* submission)
{
- ASSERT(m_frame->page());
+ DCHECK(m_frame->page());
schedule(ScheduledFormSubmission::create(document, submission, mustReplaceCurrentItem(m_frame)));
}
@@ -447,7 +447,7 @@ void NavigationScheduler::navigateTask()
void NavigationScheduler::schedule(ScheduledNavigation* redirect)
{
- ASSERT(m_frame->page());
+ DCHECK(m_frame->page());
// In a back/forward navigation, we sometimes restore history state to iframes, even though the state was generated
// dynamically and JS will try to put something different in the iframe. In this case, we will load stale things
@@ -469,7 +469,7 @@ void NavigationScheduler::startTimer()
if (!m_redirect)
return;
- ASSERT(m_frame->page());
+ DCHECK(m_frame->page());
if (m_navigateTaskFactory->isPending())
return;
if (!m_redirect->shouldStartTimer(m_frame))

Powered by Google App Engine
This is Rietveld 408576698