third_party/WebKit/Source/core/loader/NavigationPolicy.cpp - Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/NavigationPolicy.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ASSERT_UNUSED Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h ('K') | « third_party/WebKit/Source/core/loader/LinkPreloadResourceClients.h ('k') | third_party/WebKit/Source/core/loader/NavigationScheduler.h » ('j') | third_party/WebKit/Source/core/loader/TextTrackLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/NavigationPolicy.cpp

diff --git a/third_party/WebKit/Source/core/loader/NavigationPolicy.cpp b/third_party/WebKit/Source/core/loader/NavigationPolicy.cpp

index 6f855db37c4ef20e092c3bc4d039edbafb7516d8..acea00daeada5cb43365a3bc3030678c77b81de0 100644

--- a/third_party/WebKit/Source/core/loader/NavigationPolicy.cpp

+++ b/third_party/WebKit/Source/core/loader/NavigationPolicy.cpp

@@ -44,7 +44,7 @@ bool navigationPolicyFromMouseEvent(unsigned short button, bool ctrl, bool shift

if (!newTabModifier && !shift && !alt)

return false;

- ASSERT(policy);

+ DCHECK(policy);

if (newTabModifier) {

if (shift)

*policy = NavigationPolicyNewForegroundTab;