Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ASSERT_UNUSED Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp
diff --git a/third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp b/third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp
index 4968b49c3ba26d313b7f69bfd8fb507413ecc8b5..ea91f88445fe2f14296908e02060a58f29048a09 100644
--- a/third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp
+++ b/third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp
@@ -102,10 +102,10 @@ void DocumentLoadTiming::markNavigationStart()
// Allow the embedder to override navigationStart before we record it if
// they have a more accurate timestamp.
if (m_navigationStart) {
- ASSERT(m_referenceMonotonicTime && m_referenceWallTime);
+ DCHECK(m_referenceMonotonicTime && m_referenceWallTime);
return;
}
- ASSERT(!m_navigationStart && !m_referenceMonotonicTime && !m_referenceWallTime);
+ DCHECK(!m_navigationStart && !m_referenceMonotonicTime && !m_referenceWallTime);
yhirano 2016/09/12 04:33:12 How about having three DCHECKs?
hiroshige 2016/09/13 08:43:19 Done.
ensureReferenceTimesSet();
m_navigationStart = m_referenceMonotonicTime;
TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing", "navigationStart", m_navigationStart, "frame", frame());
@@ -122,7 +122,7 @@ void DocumentLoadTiming::setNavigationStart(double navigationStart)
TRACE_EVENT_MARK_WITH_TIMESTAMP1("blink.user_timing", "navigationStart", m_navigationStart, "frame", frame());
// The reference times are adjusted based on the embedder's navigationStart.
- ASSERT(m_referenceMonotonicTime && m_referenceWallTime);
+ DCHECK(m_referenceMonotonicTime && m_referenceWallTime);
m_referenceWallTime = monotonicTimeToPseudoWallTime(navigationStart);
m_referenceMonotonicTime = navigationStart;
notifyDocumentTimingChanged();

Powered by Google App Engine
This is Rietveld 408576698