third_party/WebKit/Source/core/loader/DocumentWriter.cpp - Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentWriter.cpp

Issue 2327643003: Replace ASSERT*() with DCHECK*() in core/fetch/ and core/loader/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp ('k') | third_party/WebKit/Source/core/loader/FormSubmission.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/DocumentWriter.cpp

diff --git a/third_party/WebKit/Source/core/loader/DocumentWriter.cpp b/third_party/WebKit/Source/core/loader/DocumentWriter.cpp

index 7d1ae8257b156824af8f9b49229373375660c0fc..18b8b0402efc6bad03175cd237125355bcd77a71 100644

--- a/third_party/WebKit/Source/core/loader/DocumentWriter.cpp

+++ b/third_party/WebKit/Source/core/loader/DocumentWriter.cpp

@@ -84,7 +84,7 @@ void DocumentWriter::appendReplacingData(const String& source)

void DocumentWriter::addData(const char* bytes, size_t length)

{

- ASSERT(m_parser);

+ DCHECK(m_parser);

if (m_parser->needsDecoder() && 0 < length) {

std::unique_ptr<TextResourceDecoder> decoder = m_decoderBuilder.buildFor(m_document);

m_parser->setDecoder(std::move(decoder));

@@ -95,7 +95,7 @@ void DocumentWriter::addData(const char* bytes, size_t length)

void DocumentWriter::end()

{

- ASSERT(m_document);

+ DCHECK(m_document);

if (!m_parser)

return;

@@ -112,7 +112,8 @@ void DocumentWriter::end()

void DocumentWriter::setDocumentWasLoadedAsPartOfNavigation()

{

- ASSERT(m_parser && !m_parser->isStopped());

+ DCHECK(m_parser);

+ DCHECK(!m_parser->isStopped());

m_parser->setDocumentWasLoadedAsPartOfNavigation();

}