Password bubble: Deplatformify ManagePasswordsBubbleView.

chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h

Index: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
index 16b717d2599caa1347ec8b13a419565203bfc921..5bef483e5bd68156b3a64d8a36978f7fd66ce492 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
@@ -43,14 +43,21 @@ class ManagePasswordsBubbleUIController
   // up after logging in and saving a password.
   void RemoveFromBestMatches(autofill::PasswordForm password_form);
 
-  void SavePassword();
+  // Called from the model when the user chooses to save a password; passes the
+  // action off to the FormManager.
+  virtual void SavePassword();
 
-  void NeverSavePassword();
+  // Called from the model when the user chooses to never save passwords; passes
+  // the action off to the FormManager.
+  virtual void NeverSavePassword();
 
   // Called when the bubble is opened after the icon gets displayed. We change
   // the state to know that we do not need to pop up the bubble again.
   void OnBubbleShown();
 
+  // Open a new tab, pointing to the password manager settings page.
+  virtual void NavigateToPasswordManagerSettingsPage();
+
   bool manage_passwords_icon_to_be_shown() const {
     return manage_passwords_icon_to_be_shown_;
   }
@@ -94,6 +101,7 @@ class ManagePasswordsBubbleUIController
 
  private:
   friend class content::WebContentsUserData<ManagePasswordsBubbleUIController>;
+  friend class TestManagePasswordsBubbleUIController;

[vabr (Chromium), 2014/04/10 12:35:14]

This does not seem right. TestManagePasswordsBubbleUIController is a child of
ManagePasswordsBubbleUIController, so please just make the needed private parts
of it protected, and get rid of the friend declaration. Relatives should not be
friends! :)

[Mike West, 2014/04/10 12:46:43]

You're right, of course. Not sure what I was thinking here (other than "Just
compile, damnit!" :) ).

 
   explicit ManagePasswordsBubbleUIController(
       content::WebContents* web_contents);