Password bubble: Deplatformify ManagePasswordsBubbleView.

chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_UI_CONTROLLER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_UI_CONTROLLER_H_
 
 #include "components/password_manager/core/browser/password_form_manager.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/web_contents_observer.h"
@@ skipping 25 matching lines @@
   // Called when a form is _not_ autofilled due to user blacklisting.
   void OnBlacklistBlockedAutofill();
 
   // TODO(npentrel) This ought to be changed. Best matches should be newly
   // made when opening the ManagePasswordsBubble because there may have been
   // changes to the best matches via the settings page. At the moment this also
   // fails if one deletes a password when they are autofilled, as it still shows
   // up after logging in and saving a password.
   void RemoveFromBestMatches(autofill::PasswordForm password_form);
 
-  void SavePassword();
+  // Called from the model when the user chooses to save a password; passes the
+  // action off to the FormManager.
+  virtual void SavePassword();
 
-  void NeverSavePassword();
+  // Called from the model when the user chooses to never save passwords; passes
+  // the action off to the FormManager.
+  virtual void NeverSavePassword();
 
   // Called when the bubble is opened after the icon gets displayed. We change
   // the state to know that we do not need to pop up the bubble again.
   void OnBubbleShown();
 
+  // Open a new tab, pointing to the password manager settings page.
+  virtual void NavigateToPasswordManagerSettingsPage();
+
   bool manage_passwords_icon_to_be_shown() const {
     return manage_passwords_icon_to_be_shown_;
   }
 
   bool password_to_be_saved() const {
     return password_to_be_saved_;
   }
 
   bool manage_passwords_bubble_needs_showing() const {
     return manage_passwords_bubble_needs_showing_;
@@ skipping 23 matching lines @@
     password_submitted_ = password_submitted;
   }
 
   bool autofill_blocked() const { return autofill_blocked_; }
   void set_autofill_blocked(bool autofill_blocked) {
     autofill_blocked_ = autofill_blocked;
   }
 
  private:
   friend class content::WebContentsUserData<ManagePasswordsBubbleUIController>;
+  friend class TestManagePasswordsBubbleUIController;

[vabr (Chromium), 2014/04/10 12:35:14]

This does not seem right. TestManagePasswordsBubbleUIController is a child of
ManagePasswordsBubbleUIController, so please just make the needed private parts
of it protected, and get rid of the friend declaration. Relatives should not be
friends! :)

[Mike West, 2014/04/10 12:46:43]

You're right, of course. Not sure what I was thinking here (other than "Just
compile, damnit!" :) ).

 
   explicit ManagePasswordsBubbleUIController(
       content::WebContents* web_contents);
 
   // Called when a passwordform is autofilled, when a new passwordform is
   // submitted, or when a navigation occurs to update the visibility of the
   // manage passwords icon and bubble.
   void UpdateBubbleAndIconVisibility();
 
   // content::WebContentsObserver:
@@ skipping 19 matching lines @@
   bool password_submitted_;
 
   // Stores whether autofill was blocked due to a user's decision to blacklist
   // the current site ("Never save passwords for this site").
   bool autofill_blocked_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleUIController);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_UI_CONTROLLER_H_