Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2028)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h

Issue 232753002: Password bubble: Deplatformify ManagePasswordsBubbleView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
index 31d96f80483037e8bd1d2ded6985ff48387b2def..abe6de4dee3d859f622d3f225763da4d452dacb9 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
@@ -43,14 +43,23 @@ class ManagePasswordsBubbleUIController
virtual void OnLoginsChanged(
const password_manager::PasswordStoreChangeList& changes) OVERRIDE;
- void SavePassword();
+ // Called from the model when the user chooses to save a password; passes the
+ // action off to the FormManager.
+ virtual void SavePassword();
- void NeverSavePassword();
+ // Called from the model when the user chooses to never save passwords; passes
+ // the action off to the FormManager.
+ virtual void NeverSavePassword();
// Called when the bubble is opened after the icon gets displayed. We change
// the state to know that we do not need to pop up the bubble again.
void OnBubbleShown();
+ // Open a new tab, pointing to the password manager settings page.
+ virtual void NavigateToPasswordManagerSettingsPage();
+
+ virtual const autofill::PasswordForm& PendingCredentials() const;
+
bool manage_passwords_icon_to_be_shown() const {
return manage_passwords_icon_to_be_shown_;
}
@@ -71,10 +80,6 @@ class ManagePasswordsBubbleUIController
password_to_be_saved_ = false;
}
- const autofill::PasswordForm& pending_credentials() const {
- return form_manager_->pending_credentials();
- }
-
const autofill::PasswordFormMap best_matches() const {
return password_form_map_;
}
@@ -84,12 +89,13 @@ class ManagePasswordsBubbleUIController
autofill_blocked_ = autofill_blocked;
}
- private:
- friend class content::WebContentsUserData<ManagePasswordsBubbleUIController>;
-
+ protected:
explicit ManagePasswordsBubbleUIController(
content::WebContents* web_contents);
+ private:
+ friend class content::WebContentsUserData<ManagePasswordsBubbleUIController>;
+
// Called when a passwordform is autofilled, when a new passwordform is
// submitted, or when a navigation occurs to update the visibility of the
// manage passwords icon and bubble.

Powered by Google App Engine
This is Rietveld 408576698