Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc

Issue 232753002: Password bubble: Deplatformify ManagePasswordsBubbleView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc
index c1d21e1aba68d72dd7cbde38a10198fe791f2174..d9516de0fdb8c3cca6668b850f7f317d60548daa 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc
@@ -8,7 +8,9 @@
#include "chrome/browser/password_manager/password_store_factory.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/omnibox/location_bar.h"
+#include "chrome/common/url_constants.h"
#include "components/password_manager/core/browser/password_store.h"
#include "content/public/browser/notification_service.h"
@@ -58,7 +60,7 @@ void ManagePasswordsBubbleUIController::OnPasswordSubmitted(
PasswordFormManager* form_manager) {
form_manager_.reset(form_manager);
password_form_map_ = form_manager_->best_matches();
- origin_ = pending_credentials().origin;
+ origin_ = PendingCredentials().origin;
manage_passwords_icon_to_be_shown_ = true;
password_to_be_saved_ = true;
manage_passwords_bubble_needs_showing_ = true;
@@ -117,6 +119,17 @@ void ManagePasswordsBubbleUIController::OnBubbleShown() {
unset_manage_passwords_bubble_needs_showing();
}
+void ManagePasswordsBubbleUIController::
+ NavigateToPasswordManagerSettingsPage() {
+// TODO(mkwst): chrome_pages.h is compiled out of Android. Need to figure out
+// how this navigation should work there.
+#if !defined(OS_ANDROID)
+ chrome::ShowSettingsSubPage(
+ chrome::FindBrowserWithWebContents(web_contents()),
+ chrome::kPasswordManagerSubPage);
+#endif
+}
+
void ManagePasswordsBubbleUIController::SavePassword() {
DCHECK(form_manager_.get());
form_manager_->Save();
@@ -138,3 +151,9 @@ void ManagePasswordsBubbleUIController::DidNavigateMainFrame(
manage_passwords_bubble_needs_showing_ = false;
UpdateBubbleAndIconVisibility();
}
+
+const autofill::PasswordForm& ManagePasswordsBubbleUIController::
+ PendingCredentials() const {
+ DCHECK(form_manager_);
+ return form_manager_->pending_credentials();
+}

Powered by Google App Engine
This is Rietveld 408576698