Issue 232733002: InvokeCallbackTask should use UniquePersistent to hold callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232733002: InvokeCallbackTask should use UniquePersistent to hold callback. (Closed)

Created:
6 years, 8 months ago by kouhei (in TOK)

Modified:
6 years, 8 months ago

Reviewers:
haraken, hajimehoshi, dcarney, jochen (gone - plz use gerrit), vogelheim

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, haraken

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

InvokeCallbackTask should use UniquePersistent to hold callback. Before this patch, InvokeCallbackTask was holding onto a callback using v8::Persistent, and v8::Persistent do not release on d-tor by default. This patch changes it to use UniquePersistent, so it will release callback on |~InvokeCallbackTask|. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262975

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/shell/renderer/test_runner/test_runner.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/232733002/1

6 years, 8 months ago (2014-04-10 09:09:31 UTC) #5

Message was sent while issue was closed.

Change committed as 262975

Expand Messages | Collapse Messages