content/shell/renderer/test_runner/test_runner.cc - Issue 232733002: InvokeCallbackTask should use UniquePersistent to hold callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/test_runner.cc

Issue 232733002: InvokeCallbackTask should use UniquePersistent to hold callback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/test_runner/test_runner.cc

diff --git a/content/shell/renderer/test_runner/test_runner.cc b/content/shell/renderer/test_runner/test_runner.cc

index a16d3115a37a59c6cb365c961762a3b605ff8a98..2d6694cce167ebe9499e4666d5a2db99c3753973 100644

--- a/content/shell/renderer/test_runner/test_runner.cc

+++ b/content/shell/renderer/test_runner/test_runner.cc

@@ -104,7 +104,7 @@ class InvokeCallbackTask : public WebMethodTask<content::TestRunner> {

}

private:

- v8::Persistent<v8::Function> callback_;

+ v8::UniquePersistent<v8::Function> callback_;

};

class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {

« no previous file with comments | « no previous file | no next file » | no next file with comments »