Issue 2327203002: [Merge-M54] arc: Disable shelf item creation when secondary user is active.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2327203002: [Merge-M54] arc: Disable shelf item creation when secondary user is active. (Closed)

Created:
4 years, 3 months ago by khmel

Modified:
4 years, 3 months ago

Reviewers:
reviewer

CC:
chromium-reviews, kalyank, sadrul

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Merge-M54] arc: Disable shelf item creation when secondary user is active. This CL prevents appearing an item on the shelf when Arc app gets active during the secondary user session. BUG=b/31154158 BUG=644751 BUG=642649 TEST=Manually on device TEST=Added intial unit_test coverage for Arc multi-user TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2325743002 Cr-Commit-Position: refs/heads/master@{#417434} (cherry picked from commit b70099aa14e69cb392d598768807cdb677a67dae)

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -10 lines)			Patch
M	chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc	View	4 chunks	+80 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327203002/1

4 years, 3 months ago (2016-09-09 21:20:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages