Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Issue 2325743002: arc: Disable shelf item creation when secondary user is active. (Closed)

Created:
4 years, 3 months ago by khmel
Modified:
4 years, 3 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Disable shelf item creation when secondary user is active. This CL prevents appearing an item on the shelf when Arc app gets active during the secondary user session. BUG=b/31154158 BUG=644751 BUG=642649 TEST=Manually on device TEST=Added intial unit_test coverage for Arc multi-user Committed: https://crrev.com/b70099aa14e69cb392d598768807cdb677a67dae Cr-Commit-Position: refs/heads/master@{#417434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -10 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 4 chunks +80 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
khmel
Hi Stefan, PTAL
4 years, 3 months ago (2016-09-08 19:24:59 UTC) #2
Mr4D (OOO till 08-26)
lgtm
4 years, 3 months ago (2016-09-08 22:41:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2325743002/1
4 years, 3 months ago (2016-09-08 22:42:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 23:41:23 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 23:44:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b70099aa14e69cb392d598768807cdb677a67dae
Cr-Commit-Position: refs/heads/master@{#417434}

Powered by Google App Engine
This is Rietveld 408576698