Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2326983002: Restore user state on ReloadwithoutSubResourceCacheRevalidation (Closed)

Created:
4 years, 3 months ago by Takashi Toyoshima
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, tyoshino+watch_chromium.org, jam, blink-reviews-api_chromium.org, loading-reviews_chromium.org, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, blink-reviews, kinuko+watch, Nate Chapin, android-webview-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Restore user state on ReloadwithoutSubResourceCacheRevalidation Currently, Chrome does not restore user state, scroll position and scale factor for same page navigation regardless of NonValidatingReloadOnNormalReload content feature flag. This patch connects NonValidatingReloadOnNormalReload flag to ReloadwithoutSubResourceCacheRevalidation blink feature flag, and changes the behavior to restore user state even for the same page navigation if ReloadwithoutSubResourceCacheRevalidation flag is enabled. BUG=632358 Review-Url: https://codereview.chromium.org/2257743002 Cr-Commit-Position: refs/heads/master@{#416855} (cherry picked from commit 2a56f872fc3e82ccd819db4378ae2e1ac206c116) TBR=toyoshim@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e511817baa8b186aac81dd9e2aa4e49ece5d36e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 chunk +7 lines, -2 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Takashi Toyoshima
4 years, 3 months ago (2016-09-09 05:42:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e511817baa8b186aac81dd9e2aa4e49ece5d36e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698