Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2326983002: Restore user state on ReloadwithoutSubResourceCacheRevalidation (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/runtime_features.cc ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 3cdf16253289e47b10e578a534d6adf17aacb37b..90bda829a90afa55bffa16a6184957bfe651ffe0 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -122,11 +122,10 @@ bool isReloadLoadType(FrameLoadType type)
static bool needsHistoryItemRestore(FrameLoadType type)
{
- // TODO(toyoshim): Check if this should return true for
- // FrameLoadTypeReloadMainResource.
- return type == FrameLoadTypeBackForward
- || type == FrameLoadTypeReload
- || type == FrameLoadTypeReloadBypassingCache;
+ if (!RuntimeEnabledFeatures::reloadwithoutSubResourceCacheRevalidationEnabled() && type == FrameLoadTypeReloadMainResource)
+ return false;
+ // TODO(toyoshim): Shall we return true for FrameLoadTypeInitialHistoryLoad too?
+ return type == FrameLoadTypeBackForward || isReloadLoadType(type);
}
// static
« no previous file with comments | « content/child/runtime_features.cc ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698