Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: extensions/browser/mojo/keep_alive_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/serial/serial_apitest.cc ('k') | extensions/browser/mojo/keep_alive_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/mojo/keep_alive_impl.h
diff --git a/extensions/browser/mojo/keep_alive_impl.h b/extensions/browser/mojo/keep_alive_impl.h
index d9da48f783c898716e473047014d9169d2c180be..49ec6e894b04d70ef426ccde2d0a726872e2485c 100644
--- a/extensions/browser/mojo/keep_alive_impl.h
+++ b/extensions/browser/mojo/keep_alive_impl.h
@@ -10,8 +10,7 @@
#include "base/scoped_observer.h"
#include "extensions/browser/extension_registry_observer.h"
#include "extensions/common/mojo/keep_alive.mojom.h"
-#include "mojo/public/cpp/bindings/interface_request.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "mojo/public/cpp/bindings/binding.h"
namespace content {
class BrowserContext;
@@ -28,12 +27,12 @@ class KeepAliveImpl : public KeepAlive, public ExtensionRegistryObserver {
// |request|. When the requester closes its pipe, the keep alive ends.
static void Create(content::BrowserContext* context,
const Extension* extension,
- mojo::InterfaceRequest<KeepAlive> request);
+ KeepAliveRequest request);
private:
KeepAliveImpl(content::BrowserContext* context,
const Extension* extension,
- mojo::InterfaceRequest<KeepAlive> request);
+ KeepAliveRequest request);
~KeepAliveImpl() override;
// ExtensionRegistryObserver overrides.
@@ -48,7 +47,7 @@ class KeepAliveImpl : public KeepAlive, public ExtensionRegistryObserver {
content::BrowserContext* context_;
const Extension* extension_;
ScopedObserver<ExtensionRegistry, KeepAliveImpl> extension_registry_observer_;
- mojo::StrongBinding<KeepAlive> binding_;
+ mojo::Binding<KeepAlive> binding_;
DISALLOW_COPY_AND_ASSIGN(KeepAliveImpl);
};
« no previous file with comments | « extensions/browser/api/serial/serial_apitest.cc ('k') | extensions/browser/mojo/keep_alive_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698