Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: extensions/browser/api/serial/serial_apitest.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/serial/serial_apitest.cc
diff --git a/extensions/browser/api/serial/serial_apitest.cc b/extensions/browser/api/serial/serial_apitest.cc
index 59f0412af1acb41ffdeb4dc079dc7979192e7b8f..eb9354b34ccfdf25845d8918e835ab5caf6b645e 100644
--- a/extensions/browser/api/serial/serial_apitest.cc
+++ b/extensions/browser/api/serial/serial_apitest.cc
@@ -19,6 +19,7 @@
#include "extensions/common/api/serial.h"
#include "extensions/common/switches.h"
#include "extensions/test/result_catcher.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
#include "testing/gmock/include/gmock/gmock.h"
using testing::_;
@@ -140,8 +141,9 @@ void CreateTestSerialServiceOnFileThread(
content::BrowserThread::IO));
std::unique_ptr<device::SerialDeviceEnumerator> device_enumerator(
new FakeSerialDeviceEnumerator);
- new device::SerialServiceImpl(
- connection_factory, std::move(device_enumerator), std::move(request));
+ mojo::MakeStrongBinding(base::MakeUnique<device::SerialServiceImpl>(
+ connection_factory, std::move(device_enumerator)),
+ std::move(request));
}
void CreateTestSerialService(

Powered by Google App Engine
This is Rietveld 408576698