Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3661)

Unified Diff: extensions/browser/api/mime_handler_private/mime_handler_private.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/mime_handler_private/mime_handler_private.h
diff --git a/extensions/browser/api/mime_handler_private/mime_handler_private.h b/extensions/browser/api/mime_handler_private/mime_handler_private.h
index 432c40dc9067bf670e95d5971531309759e1f45f..3c6318d208e1267e705d485902a2e5c38023d3f8 100644
--- a/extensions/browser/api/mime_handler_private/mime_handler_private.h
+++ b/extensions/browser/api/mime_handler_private/mime_handler_private.h
@@ -8,7 +8,6 @@
#include "base/callback.h"
#include "base/memory/weak_ptr.h"
#include "extensions/common/api/mime_handler.mojom.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace extensions {
class StreamContainer;
@@ -16,18 +15,16 @@ class MimeHandlerServiceImplTest;
class MimeHandlerServiceImpl : public mime_handler::MimeHandlerService {
public:
- static void Create(
- base::WeakPtr<StreamContainer> stream_container,
- mojo::InterfaceRequest<mime_handler::MimeHandlerService> request);
+ explicit MimeHandlerServiceImpl(
+ base::WeakPtr<StreamContainer> stream_container);
+ ~MimeHandlerServiceImpl() override;
+
+ static void Create(base::WeakPtr<StreamContainer> stream_container,
+ mime_handler::MimeHandlerServiceRequest request);
private:
friend class MimeHandlerServiceImplTest;
- MimeHandlerServiceImpl(
- base::WeakPtr<StreamContainer> stream_container,
- mojo::InterfaceRequest<mime_handler::MimeHandlerService> request);
- ~MimeHandlerServiceImpl() override;
-
// mime_handler::MimeHandlerService overrides.
void GetStreamInfo(const GetStreamInfoCallback& callback) override;
void AbortStream(const AbortStreamCallback& callback) override;
@@ -38,8 +35,6 @@ class MimeHandlerServiceImpl : public mime_handler::MimeHandlerService {
// A handle to the stream being handled by the MimeHandlerViewGuest.
base::WeakPtr<StreamContainer> stream_;
- mojo::StrongBinding<mime_handler::MimeHandlerService> binding_;
-
base::WeakPtrFactory<MimeHandlerServiceImpl> weak_factory_;
};

Powered by Google App Engine
This is Rietveld 408576698