Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: extensions/browser/api/mime_handler_private/mime_handler_private.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_API_MIME_HANDLER_PRIVATE_MIME_HANDLER_PRIVATE_H_ 5 #ifndef EXTENSIONS_BROWSER_API_MIME_HANDLER_PRIVATE_MIME_HANDLER_PRIVATE_H_
6 #define EXTENSIONS_BROWSER_API_MIME_HANDLER_PRIVATE_MIME_HANDLER_PRIVATE_H_ 6 #define EXTENSIONS_BROWSER_API_MIME_HANDLER_PRIVATE_MIME_HANDLER_PRIVATE_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "extensions/common/api/mime_handler.mojom.h" 10 #include "extensions/common/api/mime_handler.mojom.h"
11 #include "mojo/public/cpp/bindings/strong_binding.h"
12 11
13 namespace extensions { 12 namespace extensions {
14 class StreamContainer; 13 class StreamContainer;
15 class MimeHandlerServiceImplTest; 14 class MimeHandlerServiceImplTest;
16 15
17 class MimeHandlerServiceImpl : public mime_handler::MimeHandlerService { 16 class MimeHandlerServiceImpl : public mime_handler::MimeHandlerService {
18 public: 17 public:
19 static void Create( 18 explicit MimeHandlerServiceImpl(
20 base::WeakPtr<StreamContainer> stream_container, 19 base::WeakPtr<StreamContainer> stream_container);
21 mojo::InterfaceRequest<mime_handler::MimeHandlerService> request); 20 ~MimeHandlerServiceImpl() override;
21
22 static void Create(base::WeakPtr<StreamContainer> stream_container,
23 mime_handler::MimeHandlerServiceRequest request);
22 24
23 private: 25 private:
24 friend class MimeHandlerServiceImplTest; 26 friend class MimeHandlerServiceImplTest;
25 27
26 MimeHandlerServiceImpl(
27 base::WeakPtr<StreamContainer> stream_container,
28 mojo::InterfaceRequest<mime_handler::MimeHandlerService> request);
29 ~MimeHandlerServiceImpl() override;
30
31 // mime_handler::MimeHandlerService overrides. 28 // mime_handler::MimeHandlerService overrides.
32 void GetStreamInfo(const GetStreamInfoCallback& callback) override; 29 void GetStreamInfo(const GetStreamInfoCallback& callback) override;
33 void AbortStream(const AbortStreamCallback& callback) override; 30 void AbortStream(const AbortStreamCallback& callback) override;
34 31
35 // Invoked by the callback used to abort |stream_|. 32 // Invoked by the callback used to abort |stream_|.
36 void OnStreamClosed(const AbortStreamCallback& callback); 33 void OnStreamClosed(const AbortStreamCallback& callback);
37 34
38 // A handle to the stream being handled by the MimeHandlerViewGuest. 35 // A handle to the stream being handled by the MimeHandlerViewGuest.
39 base::WeakPtr<StreamContainer> stream_; 36 base::WeakPtr<StreamContainer> stream_;
40 37
41 mojo::StrongBinding<mime_handler::MimeHandlerService> binding_;
42
43 base::WeakPtrFactory<MimeHandlerServiceImpl> weak_factory_; 38 base::WeakPtrFactory<MimeHandlerServiceImpl> weak_factory_;
44 }; 39 };
45 40
46 } // namespace extensions 41 } // namespace extensions
47 42
48 namespace mojo { 43 namespace mojo {
49 44
50 template <> 45 template <>
51 struct TypeConverter<extensions::mime_handler::StreamInfoPtr, 46 struct TypeConverter<extensions::mime_handler::StreamInfoPtr,
52 extensions::StreamContainer> { 47 extensions::StreamContainer> {
53 static extensions::mime_handler::StreamInfoPtr Convert( 48 static extensions::mime_handler::StreamInfoPtr Convert(
54 const extensions::StreamContainer& stream); 49 const extensions::StreamContainer& stream);
55 }; 50 };
56 51
57 } // namespace mojo 52 } // namespace mojo
58 53
59 #endif // EXTENSIONS_BROWSER_API_MIME_HANDLER_PRIVATE_MIME_HANDLER_PRIVATE_H_ 54 #endif // EXTENSIONS_BROWSER_API_MIME_HANDLER_PRIVATE_MIME_HANDLER_PRIVATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698