Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2853)

Unified Diff: device/usb/mojo/device_manager_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/usb/mojo/device_impl_unittest.cc ('k') | device/usb/mojo/device_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/mojo/device_manager_impl.h
diff --git a/device/usb/mojo/device_manager_impl.h b/device/usb/mojo/device_manager_impl.h
index bf7a893d647d9b961b2df7ac057bc173c3f9b5bf..056117f00ff4dacac2bb322b8d5c71f90edfc062 100644
--- a/device/usb/mojo/device_manager_impl.h
+++ b/device/usb/mojo/device_manager_impl.h
@@ -18,7 +18,6 @@
#include "device/usb/usb_service.h"
#include "mojo/public/cpp/bindings/array.h"
#include "mojo/public/cpp/bindings/interface_request.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace base {
class SequencedTaskRunner;
@@ -42,8 +41,7 @@ class DeviceManagerImpl : public DeviceManager, public UsbService::Observer {
mojo::InterfaceRequest<DeviceManager> request);
DeviceManagerImpl(base::WeakPtr<PermissionProvider> permission_provider,
- UsbService* usb_service,
- mojo::InterfaceRequest<DeviceManager> request);
+ UsbService* usb_service);
~DeviceManagerImpl() override;
void set_connection_error_handler(const base::Closure& error_handler) {
@@ -78,7 +76,6 @@ class DeviceManagerImpl : public DeviceManager, public UsbService::Observer {
base::Closure connection_error_handler_;
- mojo::StrongBinding<DeviceManager> binding_;
base::WeakPtrFactory<DeviceManagerImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(DeviceManagerImpl);
« no previous file with comments | « device/usb/mojo/device_impl_unittest.cc ('k') | device/usb/mojo/device_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698