Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: device/usb/mojo/device_manager_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/usb/mojo/device_impl_unittest.cc ('k') | device/usb/mojo/device_manager_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_USB_MOJO_DEVICE_MANAGER_IMPL_H_ 5 #ifndef DEVICE_USB_MOJO_DEVICE_MANAGER_IMPL_H_
6 #define DEVICE_USB_MOJO_DEVICE_MANAGER_IMPL_H_ 6 #define DEVICE_USB_MOJO_DEVICE_MANAGER_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <queue> 9 #include <queue>
10 #include <set> 10 #include <set>
11 11
12 #include "base/callback.h" 12 #include "base/callback.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/memory/ref_counted.h" 14 #include "base/memory/ref_counted.h"
15 #include "base/memory/weak_ptr.h" 15 #include "base/memory/weak_ptr.h"
16 #include "base/scoped_observer.h" 16 #include "base/scoped_observer.h"
17 #include "device/usb/public/interfaces/device_manager.mojom.h" 17 #include "device/usb/public/interfaces/device_manager.mojom.h"
18 #include "device/usb/usb_service.h" 18 #include "device/usb/usb_service.h"
19 #include "mojo/public/cpp/bindings/array.h" 19 #include "mojo/public/cpp/bindings/array.h"
20 #include "mojo/public/cpp/bindings/interface_request.h" 20 #include "mojo/public/cpp/bindings/interface_request.h"
21 #include "mojo/public/cpp/bindings/strong_binding.h"
22 21
23 namespace base { 22 namespace base {
24 class SequencedTaskRunner; 23 class SequencedTaskRunner;
25 } 24 }
26 25
27 namespace device { 26 namespace device {
28 27
29 class UsbDevice; 28 class UsbDevice;
30 class UsbDeviceFilter; 29 class UsbDeviceFilter;
31 class UsbDeviceHandle; 30 class UsbDeviceHandle;
32 31
33 namespace usb { 32 namespace usb {
34 33
35 class PermissionProvider; 34 class PermissionProvider;
36 35
37 // Implementation of the public DeviceManager interface. This interface can be 36 // Implementation of the public DeviceManager interface. This interface can be
38 // requested from the devices app located at "mojo:devices", if available. 37 // requested from the devices app located at "mojo:devices", if available.
39 class DeviceManagerImpl : public DeviceManager, public UsbService::Observer { 38 class DeviceManagerImpl : public DeviceManager, public UsbService::Observer {
40 public: 39 public:
41 static void Create(base::WeakPtr<PermissionProvider> permission_provider, 40 static void Create(base::WeakPtr<PermissionProvider> permission_provider,
42 mojo::InterfaceRequest<DeviceManager> request); 41 mojo::InterfaceRequest<DeviceManager> request);
43 42
44 DeviceManagerImpl(base::WeakPtr<PermissionProvider> permission_provider, 43 DeviceManagerImpl(base::WeakPtr<PermissionProvider> permission_provider,
45 UsbService* usb_service, 44 UsbService* usb_service);
46 mojo::InterfaceRequest<DeviceManager> request);
47 ~DeviceManagerImpl() override; 45 ~DeviceManagerImpl() override;
48 46
49 void set_connection_error_handler(const base::Closure& error_handler) { 47 void set_connection_error_handler(const base::Closure& error_handler) {
50 connection_error_handler_ = error_handler; 48 connection_error_handler_ = error_handler;
51 } 49 }
52 50
53 private: 51 private:
54 // DeviceManager implementation: 52 // DeviceManager implementation:
55 void GetDevices(EnumerationOptionsPtr options, 53 void GetDevices(EnumerationOptionsPtr options,
56 const GetDevicesCallback& callback) override; 54 const GetDevicesCallback& callback) override;
(...skipping 14 matching lines...) Expand all
71 void MaybeRunDeviceChangesCallback(); 69 void MaybeRunDeviceChangesCallback();
72 70
73 base::WeakPtr<PermissionProvider> permission_provider_; 71 base::WeakPtr<PermissionProvider> permission_provider_;
74 72
75 UsbService* usb_service_; 73 UsbService* usb_service_;
76 ScopedObserver<UsbService, UsbService::Observer> observer_; 74 ScopedObserver<UsbService, UsbService::Observer> observer_;
77 DeviceManagerClientPtr client_; 75 DeviceManagerClientPtr client_;
78 76
79 base::Closure connection_error_handler_; 77 base::Closure connection_error_handler_;
80 78
81 mojo::StrongBinding<DeviceManager> binding_;
82 base::WeakPtrFactory<DeviceManagerImpl> weak_factory_; 79 base::WeakPtrFactory<DeviceManagerImpl> weak_factory_;
83 80
84 DISALLOW_COPY_AND_ASSIGN(DeviceManagerImpl); 81 DISALLOW_COPY_AND_ASSIGN(DeviceManagerImpl);
85 }; 82 };
86 83
87 } // namespace usb 84 } // namespace usb
88 } // namespace device 85 } // namespace device
89 86
90 #endif // DEVICE_USB_MOJO_DEVICE_MANAGER_IMPL_H_ 87 #endif // DEVICE_USB_MOJO_DEVICE_MANAGER_IMPL_H_
OLDNEW
« no previous file with comments | « device/usb/mojo/device_impl_unittest.cc ('k') | device/usb/mojo/device_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698