Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: device/serial/serial_service_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/serial_connection_unittest.cc ('k') | device/serial/serial_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/serial_service_impl.h
diff --git a/device/serial/serial_service_impl.h b/device/serial/serial_service_impl.h
index 464e4aede2f4e08e34eb881ea8ade667a343278c..68538974541ec2ee5739c95bf5f206fcc5138621 100644
--- a/device/serial/serial_service_impl.h
+++ b/device/serial/serial_service_impl.h
@@ -14,17 +14,15 @@
#include "device/serial/serial.mojom.h"
#include "device/serial/serial_connection_factory.h"
#include "device/serial/serial_device_enumerator.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace device {
class SerialServiceImpl : public serial::SerialService {
public:
+ explicit SerialServiceImpl(
+ scoped_refptr<SerialConnectionFactory> connection_factory);
SerialServiceImpl(scoped_refptr<SerialConnectionFactory> connection_factory,
- mojo::InterfaceRequest<serial::SerialService> request);
- SerialServiceImpl(scoped_refptr<SerialConnectionFactory> connection_factory,
- std::unique_ptr<SerialDeviceEnumerator> device_enumerator,
- mojo::InterfaceRequest<serial::SerialService> request);
+ std::unique_ptr<SerialDeviceEnumerator> device_enumerator);
~SerialServiceImpl() override;
static void Create(scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
@@ -52,7 +50,6 @@ class SerialServiceImpl : public serial::SerialService {
std::unique_ptr<SerialDeviceEnumerator> device_enumerator_;
scoped_refptr<SerialConnectionFactory> connection_factory_;
- mojo::StrongBinding<serial::SerialService> binding_;
DISALLOW_COPY_AND_ASSIGN(SerialServiceImpl);
};
« no previous file with comments | « device/serial/serial_connection_unittest.cc ('k') | device/serial/serial_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698