Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: device/serial/serial_service_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/serial/serial_connection_unittest.cc ('k') | device/serial/serial_service_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_ 5 #ifndef DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_
6 #define DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_ 6 #define DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/single_thread_task_runner.h" 11 #include "base/single_thread_task_runner.h"
12 #include "base/threading/thread_task_runner_handle.h" 12 #include "base/threading/thread_task_runner_handle.h"
13 #include "device/serial/data_stream.mojom.h" 13 #include "device/serial/data_stream.mojom.h"
14 #include "device/serial/serial.mojom.h" 14 #include "device/serial/serial.mojom.h"
15 #include "device/serial/serial_connection_factory.h" 15 #include "device/serial/serial_connection_factory.h"
16 #include "device/serial/serial_device_enumerator.h" 16 #include "device/serial/serial_device_enumerator.h"
17 #include "mojo/public/cpp/bindings/strong_binding.h"
18 17
19 namespace device { 18 namespace device {
20 19
21 class SerialServiceImpl : public serial::SerialService { 20 class SerialServiceImpl : public serial::SerialService {
22 public: 21 public:
22 explicit SerialServiceImpl(
23 scoped_refptr<SerialConnectionFactory> connection_factory);
23 SerialServiceImpl(scoped_refptr<SerialConnectionFactory> connection_factory, 24 SerialServiceImpl(scoped_refptr<SerialConnectionFactory> connection_factory,
24 mojo::InterfaceRequest<serial::SerialService> request); 25 std::unique_ptr<SerialDeviceEnumerator> device_enumerator);
25 SerialServiceImpl(scoped_refptr<SerialConnectionFactory> connection_factory,
26 std::unique_ptr<SerialDeviceEnumerator> device_enumerator,
27 mojo::InterfaceRequest<serial::SerialService> request);
28 ~SerialServiceImpl() override; 26 ~SerialServiceImpl() override;
29 27
30 static void Create(scoped_refptr<base::SingleThreadTaskRunner> io_task_runner, 28 static void Create(scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
31 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner, 29 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
32 mojo::InterfaceRequest<serial::SerialService> request); 30 mojo::InterfaceRequest<serial::SerialService> request);
33 static void CreateOnMessageLoop( 31 static void CreateOnMessageLoop(
34 scoped_refptr<base::SingleThreadTaskRunner> task_runner, 32 scoped_refptr<base::SingleThreadTaskRunner> task_runner,
35 scoped_refptr<base::SingleThreadTaskRunner> io_task_runner, 33 scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
36 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner, 34 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
37 mojo::InterfaceRequest<serial::SerialService> request); 35 mojo::InterfaceRequest<serial::SerialService> request);
38 36
39 // SerialService overrides. 37 // SerialService overrides.
40 void GetDevices(const GetDevicesCallback& callback) override; 38 void GetDevices(const GetDevicesCallback& callback) override;
41 void Connect( 39 void Connect(
42 const mojo::String& path, 40 const mojo::String& path,
43 serial::ConnectionOptionsPtr options, 41 serial::ConnectionOptionsPtr options,
44 mojo::InterfaceRequest<serial::Connection> connection_request, 42 mojo::InterfaceRequest<serial::Connection> connection_request,
45 mojo::InterfaceRequest<serial::DataSink> sink, 43 mojo::InterfaceRequest<serial::DataSink> sink,
46 mojo::InterfaceRequest<serial::DataSource> source, 44 mojo::InterfaceRequest<serial::DataSource> source,
47 mojo::InterfacePtr<serial::DataSourceClient> source_client) override; 45 mojo::InterfacePtr<serial::DataSourceClient> source_client) override;
48 46
49 private: 47 private:
50 SerialDeviceEnumerator* GetDeviceEnumerator(); 48 SerialDeviceEnumerator* GetDeviceEnumerator();
51 bool IsValidPath(const mojo::String& path); 49 bool IsValidPath(const mojo::String& path);
52 50
53 std::unique_ptr<SerialDeviceEnumerator> device_enumerator_; 51 std::unique_ptr<SerialDeviceEnumerator> device_enumerator_;
54 scoped_refptr<SerialConnectionFactory> connection_factory_; 52 scoped_refptr<SerialConnectionFactory> connection_factory_;
55 mojo::StrongBinding<serial::SerialService> binding_;
56 53
57 DISALLOW_COPY_AND_ASSIGN(SerialServiceImpl); 54 DISALLOW_COPY_AND_ASSIGN(SerialServiceImpl);
58 }; 55 };
59 56
60 } // namespace device 57 } // namespace device
61 58
62 #endif // DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_ 59 #endif // DEVICE_SERIAL_SERIAL_SERVICE_IMPL_H_
OLDNEW
« no previous file with comments | « device/serial/serial_connection_unittest.cc ('k') | device/serial/serial_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698