Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2317)

Unified Diff: device/serial/serial_service_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/serial_service_impl.h ('k') | device/serial/serial_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/serial_service_impl.cc
diff --git a/device/serial/serial_service_impl.cc b/device/serial/serial_service_impl.cc
index 97ad57f86cc24084a6f94d100da6b2142aa65824..224caa0a835e5a2b7152eab1661a2796547969b1 100644
--- a/device/serial/serial_service_impl.cc
+++ b/device/serial/serial_service_impl.cc
@@ -12,36 +12,32 @@
#include "base/bind.h"
#include "base/location.h"
#include "device/serial/serial_io_handler.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
namespace device {
SerialServiceImpl::SerialServiceImpl(
- scoped_refptr<SerialConnectionFactory> connection_factory,
- mojo::InterfaceRequest<serial::SerialService> request)
- : connection_factory_(connection_factory),
- binding_(this, std::move(request)) {}
+ scoped_refptr<SerialConnectionFactory> connection_factory)
+ : connection_factory_(connection_factory) {}
SerialServiceImpl::SerialServiceImpl(
scoped_refptr<SerialConnectionFactory> connection_factory,
- std::unique_ptr<SerialDeviceEnumerator> device_enumerator,
- mojo::InterfaceRequest<serial::SerialService> request)
+ std::unique_ptr<SerialDeviceEnumerator> device_enumerator)
: device_enumerator_(std::move(device_enumerator)),
- connection_factory_(connection_factory),
- binding_(this, std::move(request)) {}
+ connection_factory_(connection_factory) {}
-SerialServiceImpl::~SerialServiceImpl() {
-}
+SerialServiceImpl::~SerialServiceImpl() {}
// static
void SerialServiceImpl::Create(
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
mojo::InterfaceRequest<serial::SerialService> request) {
- new SerialServiceImpl(
- new SerialConnectionFactory(
+ mojo::MakeStrongBinding(
+ base::MakeUnique<SerialServiceImpl>(new SerialConnectionFactory(
base::Bind(SerialIoHandler::Create,
base::ThreadTaskRunnerHandle::Get(), ui_task_runner),
- io_task_runner),
+ io_task_runner)),
std::move(request));
}
« no previous file with comments | « device/serial/serial_service_impl.h ('k') | device/serial/serial_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698