Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2966)

Unified Diff: device/generic_sensor/sensor_provider_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/generic_sensor/sensor_impl.cc ('k') | device/generic_sensor/sensor_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/generic_sensor/sensor_provider_impl.h
diff --git a/device/generic_sensor/sensor_provider_impl.h b/device/generic_sensor/sensor_provider_impl.h
index fa88f2da345d1f0da05bea22f6a066ec3985fd00..b46d59ac5224f0579408b1e3e2a046ed9dbdaae9 100644
--- a/device/generic_sensor/sensor_provider_impl.h
+++ b/device/generic_sensor/sensor_provider_impl.h
@@ -7,7 +7,6 @@
#include "base/macros.h"
#include "device/generic_sensor/public/interfaces/sensor_provider.mojom.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace device {
@@ -18,21 +17,20 @@ class PlatformSensorProvider;
// of PlatformSensor which are used by SensorImpl.
class SensorProviderImpl final : public mojom::SensorProvider {
public:
- static void Create(mojo::InterfaceRequest<mojom::SensorProvider> request);
+ static void Create(mojom::SensorProviderRequest request);
~SensorProviderImpl() override;
private:
- SensorProviderImpl(mojo::InterfaceRequest<mojom::SensorProvider> request,
- PlatformSensorProvider* provider);
+ explicit SensorProviderImpl(PlatformSensorProvider* provider);
// SensorProvider implementation.
void GetSensor(mojom::SensorType type,
mojom::SensorRequest sensor_request,
const GetSensorCallback& callback) override;
- mojo::StrongBinding<mojom::SensorProvider> binding_;
PlatformSensorProvider* provider_;
+
DISALLOW_COPY_AND_ASSIGN(SensorProviderImpl);
};
« no previous file with comments | « device/generic_sensor/sensor_impl.cc ('k') | device/generic_sensor/sensor_provider_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698