Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: device/generic_sensor/sensor_provider_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/generic_sensor/sensor_impl.cc ('k') | device/generic_sensor/sensor_provider_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_GENERIC_SENSOR_SENSOR_PROVIDER_IMPL_H_ 5 #ifndef DEVICE_GENERIC_SENSOR_SENSOR_PROVIDER_IMPL_H_
6 #define DEVICE_GENERIC_SENSOR_SENSOR_PROVIDER_IMPL_H_ 6 #define DEVICE_GENERIC_SENSOR_SENSOR_PROVIDER_IMPL_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "device/generic_sensor/public/interfaces/sensor_provider.mojom.h" 9 #include "device/generic_sensor/public/interfaces/sensor_provider.mojom.h"
10 #include "mojo/public/cpp/bindings/strong_binding.h"
11 10
12 namespace device { 11 namespace device {
13 12
14 class PlatformSensorProvider; 13 class PlatformSensorProvider;
15 14
16 // Implementation of SensorProvider mojo interface. 15 // Implementation of SensorProvider mojo interface.
17 // Uses PlatformSensorProvider singleton to create platform specific instances 16 // Uses PlatformSensorProvider singleton to create platform specific instances
18 // of PlatformSensor which are used by SensorImpl. 17 // of PlatformSensor which are used by SensorImpl.
19 class SensorProviderImpl final : public mojom::SensorProvider { 18 class SensorProviderImpl final : public mojom::SensorProvider {
20 public: 19 public:
21 static void Create(mojo::InterfaceRequest<mojom::SensorProvider> request); 20 static void Create(mojom::SensorProviderRequest request);
22 21
23 ~SensorProviderImpl() override; 22 ~SensorProviderImpl() override;
24 23
25 private: 24 private:
26 SensorProviderImpl(mojo::InterfaceRequest<mojom::SensorProvider> request, 25 explicit SensorProviderImpl(PlatformSensorProvider* provider);
27 PlatformSensorProvider* provider);
28 26
29 // SensorProvider implementation. 27 // SensorProvider implementation.
30 void GetSensor(mojom::SensorType type, 28 void GetSensor(mojom::SensorType type,
31 mojom::SensorRequest sensor_request, 29 mojom::SensorRequest sensor_request,
32 const GetSensorCallback& callback) override; 30 const GetSensorCallback& callback) override;
33 31
34 mojo::StrongBinding<mojom::SensorProvider> binding_;
35 PlatformSensorProvider* provider_; 32 PlatformSensorProvider* provider_;
33
36 DISALLOW_COPY_AND_ASSIGN(SensorProviderImpl); 34 DISALLOW_COPY_AND_ASSIGN(SensorProviderImpl);
37 }; 35 };
38 36
39 } // namespace device 37 } // namespace device
40 38
41 #endif // DEVICE_GENERIC_SENSOR_SENSOR_PROVIDER_IMPL_H_ 39 #endif // DEVICE_GENERIC_SENSOR_SENSOR_PROVIDER_IMPL_H_
OLDNEW
« no previous file with comments | « device/generic_sensor/sensor_impl.cc ('k') | device/generic_sensor/sensor_provider_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698