Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: device/battery/battery_monitor_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/utility/shell_content_utility_client.cc ('k') | device/battery/battery_monitor_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/battery/battery_monitor_impl.h
diff --git a/device/battery/battery_monitor_impl.h b/device/battery/battery_monitor_impl.h
index b03748a51afc67bc181db5ca4c5353b9908d8e01..e1a23a4b24ebc74c0a8a4fc8e8533a330ee0de82 100644
--- a/device/battery/battery_monitor_impl.h
+++ b/device/battery/battery_monitor_impl.h
@@ -11,19 +11,17 @@
#include "device/battery/battery_export.h"
#include "device/battery/battery_monitor.mojom.h"
#include "device/battery/battery_status_service.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace device {
class BatteryMonitorImpl : public BatteryMonitor {
public:
- DEVICE_BATTERY_EXPORT static void Create(
- mojo::InterfaceRequest<BatteryMonitor> request);
+ DEVICE_BATTERY_EXPORT static void Create(BatteryMonitorRequest request);
- private:
- explicit BatteryMonitorImpl(mojo::InterfaceRequest<BatteryMonitor> request);
+ BatteryMonitorImpl();
~BatteryMonitorImpl() override;
+ private:
// BatteryMonitor methods:
void QueryNextStatus(const QueryNextStatusCallback& callback) override;
@@ -31,7 +29,6 @@ class BatteryMonitorImpl : public BatteryMonitor {
void DidChange(const BatteryStatus& battery_status);
void ReportStatus();
- mojo::StrongBinding<BatteryMonitor> binding_;
std::unique_ptr<BatteryStatusService::BatteryUpdateSubscription>
subscription_;
QueryNextStatusCallback callback_;
« no previous file with comments | « content/shell/utility/shell_content_utility_client.cc ('k') | device/battery/battery_monitor_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698