Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: content/browser/loader/url_loader_factory_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/hyphenation/hyphenation_impl.cc ('k') | content/browser/loader/url_loader_factory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/url_loader_factory_impl.h
diff --git a/content/browser/loader/url_loader_factory_impl.h b/content/browser/loader/url_loader_factory_impl.h
index 28fd1ee99d71628d2ff4f96514febe3778d413ec..52e957b5e18b6a766d96d99a11a678db2133eb83 100644
--- a/content/browser/loader/url_loader_factory_impl.h
+++ b/content/browser/loader/url_loader_factory_impl.h
@@ -10,7 +10,6 @@
#include "content/common/content_export.h"
#include "content/common/url_loader_factory.mojom.h"
#include "mojo/public/cpp/bindings/interface_request.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace content {
@@ -31,15 +30,13 @@ class URLLoaderFactoryImpl final : public mojom::URLLoaderFactory {
// StrongBinding in it, so this function doesn't return the instance.
CONTENT_EXPORT static void Create(
scoped_refptr<ResourceMessageFilter> resource_message_filter,
- mojo::InterfaceRequest<mojom::URLLoaderFactory> request);
+ mojom::URLLoaderFactoryRequest request);
private:
- URLLoaderFactoryImpl(
- scoped_refptr<ResourceMessageFilter> resource_message_filter,
- mojo::InterfaceRequest<mojom::URLLoaderFactory> request);
+ explicit URLLoaderFactoryImpl(
+ scoped_refptr<ResourceMessageFilter> resource_message_filter);
scoped_refptr<ResourceMessageFilter> resource_message_filter_;
- mojo::StrongBinding<mojom::URLLoaderFactory> binding_;
DISALLOW_COPY_AND_ASSIGN(URLLoaderFactoryImpl);
};
« no previous file with comments | « content/browser/hyphenation/hyphenation_impl.cc ('k') | content/browser/loader/url_loader_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698