Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: components/filesystem/file_system_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/filesystem/file_system_app.cc ('k') | components/filesystem/file_system_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/file_system_impl.h
diff --git a/components/filesystem/file_system_impl.h b/components/filesystem/file_system_impl.h
index 682d3b679d7ffa0f911d2b3941706c806edac166..8e8abd268d2b55272554d4c81b54254b1b360664 100644
--- a/components/filesystem/file_system_impl.h
+++ b/components/filesystem/file_system_impl.h
@@ -10,7 +10,6 @@
#include "components/filesystem/public/interfaces/file_system.mojom.h"
#include "components/filesystem/shared_temp_dir.h"
#include "mojo/public/cpp/bindings/interface_request.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace base {
class FilePath;
@@ -31,21 +30,19 @@ class FileSystemImpl : public mojom::FileSystem {
// |persistent_dir| is the directory served to callers of
// |OpenPersistentFileSystem().
FileSystemImpl(const shell::Identity& remote_identity,
- mojo::InterfaceRequest<mojom::FileSystem> request,
base::FilePath persistent_dir,
scoped_refptr<LockTable> lock_table);
~FileSystemImpl() override;
// |Files| implementation:
- void OpenTempDirectory(mojo::InterfaceRequest<mojom::Directory> directory,
+ void OpenTempDirectory(mojom::DirectoryRequest directory,
const OpenTempDirectoryCallback& callback) override;
void OpenPersistentFileSystem(
- mojo::InterfaceRequest<mojom::Directory> directory,
+ mojom::DirectoryRequest directory,
const OpenPersistentFileSystemCallback& callback) override;
private:
const std::string remote_application_name_;
- mojo::StrongBinding<mojom::FileSystem> binding_;
scoped_refptr<LockTable> lock_table_;
base::FilePath persistent_dir_;
« no previous file with comments | « components/filesystem/file_system_app.cc ('k') | components/filesystem/file_system_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698