Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: components/filesystem/file_system_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/filesystem/file_system_app.cc ('k') | components/filesystem/file_system_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FILESYSTEM_FILE_SYSTEM_IMPL_H_ 5 #ifndef COMPONENTS_FILESYSTEM_FILE_SYSTEM_IMPL_H_
6 #define COMPONENTS_FILESYSTEM_FILE_SYSTEM_IMPL_H_ 6 #define COMPONENTS_FILESYSTEM_FILE_SYSTEM_IMPL_H_
7 7
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "components/filesystem/public/interfaces/file_system.mojom.h" 10 #include "components/filesystem/public/interfaces/file_system.mojom.h"
11 #include "components/filesystem/shared_temp_dir.h" 11 #include "components/filesystem/shared_temp_dir.h"
12 #include "mojo/public/cpp/bindings/interface_request.h" 12 #include "mojo/public/cpp/bindings/interface_request.h"
13 #include "mojo/public/cpp/bindings/strong_binding.h"
14 13
15 namespace base { 14 namespace base {
16 class FilePath; 15 class FilePath;
17 } 16 }
18 17
19 namespace shell { 18 namespace shell {
20 class Identity; 19 class Identity;
21 } 20 }
22 21
23 namespace filesystem { 22 namespace filesystem {
24 class FileSystemApp; 23 class FileSystemApp;
25 24
26 class LockTable; 25 class LockTable;
27 26
28 // The base implementation of FileSystemImpl. 27 // The base implementation of FileSystemImpl.
29 class FileSystemImpl : public mojom::FileSystem { 28 class FileSystemImpl : public mojom::FileSystem {
30 public: 29 public:
31 // |persistent_dir| is the directory served to callers of 30 // |persistent_dir| is the directory served to callers of
32 // |OpenPersistentFileSystem(). 31 // |OpenPersistentFileSystem().
33 FileSystemImpl(const shell::Identity& remote_identity, 32 FileSystemImpl(const shell::Identity& remote_identity,
34 mojo::InterfaceRequest<mojom::FileSystem> request,
35 base::FilePath persistent_dir, 33 base::FilePath persistent_dir,
36 scoped_refptr<LockTable> lock_table); 34 scoped_refptr<LockTable> lock_table);
37 ~FileSystemImpl() override; 35 ~FileSystemImpl() override;
38 36
39 // |Files| implementation: 37 // |Files| implementation:
40 void OpenTempDirectory(mojo::InterfaceRequest<mojom::Directory> directory, 38 void OpenTempDirectory(mojom::DirectoryRequest directory,
41 const OpenTempDirectoryCallback& callback) override; 39 const OpenTempDirectoryCallback& callback) override;
42 void OpenPersistentFileSystem( 40 void OpenPersistentFileSystem(
43 mojo::InterfaceRequest<mojom::Directory> directory, 41 mojom::DirectoryRequest directory,
44 const OpenPersistentFileSystemCallback& callback) override; 42 const OpenPersistentFileSystemCallback& callback) override;
45 43
46 private: 44 private:
47 const std::string remote_application_name_; 45 const std::string remote_application_name_;
48 mojo::StrongBinding<mojom::FileSystem> binding_;
49 scoped_refptr<LockTable> lock_table_; 46 scoped_refptr<LockTable> lock_table_;
50 47
51 base::FilePath persistent_dir_; 48 base::FilePath persistent_dir_;
52 49
53 DISALLOW_COPY_AND_ASSIGN(FileSystemImpl); 50 DISALLOW_COPY_AND_ASSIGN(FileSystemImpl);
54 }; 51 };
55 52
56 } // namespace filesystem 53 } // namespace filesystem
57 54
58 #endif // COMPONENTS_FILESYSTEM_FILE_SYSTEM_IMPL_H_ 55 #endif // COMPONENTS_FILESYSTEM_FILE_SYSTEM_IMPL_H_
OLDNEW
« no previous file with comments | « components/filesystem/file_system_app.cc ('k') | components/filesystem/file_system_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698